Skip to content

Commit e5a105f

Browse files
committed
remove TODOs, old comment and tested elsewhere
1 parent 51ec346 commit e5a105f

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

python/_tskitmodule.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8203,7 +8203,6 @@ TreeSequence_two_locus_count_stat(TreeSequence *self, PyObject *args, PyObject *
82038203
.summary_func = summary_func,
82048204
.norm_func = norm_func,
82058205
};
8206-
// TODO: deal with null norm func, need general stat.
82078206
err = tsk_treeseq_two_locus_count_general_stat(self->tree_sequence, num_sample_sets,
82088207
PyArray_DATA(sample_set_sizes_array), PyArray_DATA(sample_sets_array),
82098208
output_dim, general_two_locus_count_stat_func, params,

python/tests/test_python_c.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2097,13 +2097,6 @@ def norm_func(X, n, nA, nB):
20972097
method(ss_sizes, ss, lambda a, b: 1, norm_func, 1, True, *site_args)
20982098
with pytest.raises(ValueError, match="length 2; must be 1"):
20992099
method(ss_sizes, ss, lambda a, b: [1, 2], norm_func, 1, True, *site_args)
2100-
# TODO: Cannot test without multiallelic sites
2101-
# with pytest.raises(ValueError, match="summary function.*must be 1D"):
2102-
# method(ss_sizes, ss, stat_func, lambda a, b, c, d: 1, 1, True, *site_args)
2103-
# with pytest.raises(ValueError, match="length 2; must be 1"):
2104-
# method(
2105-
# ss_sizes, ss, stat_func, lambda a, b, c, d: [1, 2], 1, True, *site_args
2106-
# )
21072100
# C API errors
21082101
with pytest.raises(tskit.LibraryError, match="TSK_ERR_STAT_UNSORTED_SITES"):
21092102
bad_sites = np.array([1, 0, 2], dtype=np.int32)

0 commit comments

Comments
 (0)