Skip to content

Add test for minidom#3146

Merged
benjeffery merged 1 commit into
tskit-dev:mainfrom
benjeffery:minidom-snafu
Apr 28, 2025
Merged

Add test for minidom#3146
benjeffery merged 1 commit into
tskit-dev:mainfrom
benjeffery:minidom-snafu

Conversation

@benjeffery

Copy link
Copy Markdown
Member

Test to ensure #3144 is not repeated.

@codecov

codecov Bot commented Apr 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (83f8af8) to head (70cd317).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3146   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files          29       29           
  Lines       32225    32225           
  Branches     5890     5890           
=======================================
  Hits        28913    28913           
  Misses       1882     1882           
  Partials     1430     1430           
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.24% <ø> (ø)
python-tests 98.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery benjeffery force-pushed the minidom-snafu branch 2 times, most recently from 68ffd50 to 7a89676 Compare April 28, 2025 13:50
@jeromekelleher

Copy link
Copy Markdown
Member

This is such a weird once off that I'm not sure it's worth stressing about? Great if we can make this test work easily, but let's not worry about it if not.

@benjeffery

benjeffery commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

Theres a few pushes here as I wanted to check the test failed without the new fix, should be ready to go now, only adds 2s to CI time.

@mergify

mergify Bot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #3146 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@benjeffery benjeffery added this pull request to the merge queue Apr 28, 2025
@benjeffery benjeffery removed this pull request from the merge queue due to a manual request Apr 28, 2025
@benjeffery benjeffery merged commit c05903c into tskit-dev:main Apr 28, 2025
@benjeffery benjeffery deleted the minidom-snafu branch April 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants