Add test for minidom#3146
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3146 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 29 29
Lines 32225 32225
Branches 5890 5890
=======================================
Hits 28913 28913
Misses 1882 1882
Partials 1430 1430
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
68ffd50 to
7a89676
Compare
7a89676 to
70cd317
Compare
|
This is such a weird once off that I'm not sure it's worth stressing about? Great if we can make this test work easily, but let's not worry about it if not. |
|
Theres a few pushes here as I wanted to check the test failed without the new fix, should be ready to go now, only adds 2s to CI time. |
|
This pull request has been removed from the queue for the following reason: Pull request #3146 has been dequeued. The pull request rule doesn't match anymore. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Test to ensure #3144 is not repeated.