Skip to content

Correct assert_equals message when tables differ by content and metadata#3162

Merged
jeromekelleher merged 1 commit into
tskit-dev:mainfrom
benjeffery:correct-assert-equals
May 15, 2025
Merged

Correct assert_equals message when tables differ by content and metadata#3162
jeromekelleher merged 1 commit into
tskit-dev:mainfrom
benjeffery:correct-assert-equals

Conversation

@benjeffery

Copy link
Copy Markdown
Member

Fixes #3161

@benjeffery benjeffery force-pushed the correct-assert-equals branch from b95e006 to 639480a Compare May 14, 2025 23:44
@codecov

codecov Bot commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (c914b8b) to head (639480a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3162      +/-   ##
==========================================
+ Coverage   89.59%   89.60%   +0.01%     
==========================================
  Files          28       28              
  Lines       31895    31895              
  Branches     5857     5857              
==========================================
+ Hits        28575    28579       +4     
+ Misses       1888     1886       -2     
+ Partials     1432     1430       -2     
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.84% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/tables.py 99.34% <100.00%> (+0.37%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromekelleher jeromekelleher added this pull request to the merge queue May 15, 2025
Merged via the queue into tskit-dev:main with commit 4187575 May 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableCollection.assert_equals reports the wrong reason

2 participants