add URL parameter authentication support#1464
Open
tantara wants to merge 2 commits into
Open
Conversation
Allow authentication via URL parameter as an alternative to HTTP Basic Auth header. This enables authentication in scenarios where headers cannot be easily set. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Correct the return value check for lws_get_urlarg_by_name to properly detect when the parameter is present. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ee05f21 to
a9b2d19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow authentication via URL parameter as an alternative to HTTP Basic Auth header. This enables authentication in scenarios where headers cannot be easily set.
Background
I'm building a react library react-ttyd to integrate
ttydwith react applications. Since browser doesn't allow to update header with WebSocket, I parse and verifycredentialfrom url parameters.Example