Fix items discovered via SonarCloud (#58)

Author: tspence

README.md

@@ -1,8 +1,8 @@
 [![NuGet](https://img.shields.io/nuget/v/CSVFile.svg?style=plastic)](https://www.nuget.org/packages/CSVFile/)
 ![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/tspence/csharp-csv-reader/dotnet.yml?branch=main)
-[![SonarCloud Coverage](https://sonarcloud.io/api/project_badges/measure?project=tspence_csharp-csv-reader&metric=coverage)](https://sonarcloud.io/component_measures/metric/coverage/list?id=tspence_csharp-csv-reader)
-[![SonarCloud Bugs](https://sonarcloud.io/api/project_badges/measure?project=tspence_csharp-csv-reader&metric=bugs)](https://sonarcloud.io/component_measures/metric/reliability_rating/list?id=tspence_csharp-csv-reader)
-[![SonarCloud Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=tspence_csharp-csv-reader&metric=vulnerabilities)](https://sonarcloud.io/component_measures/metric/security_rating/list?id=tspence_csharp-csv-reader)
+[![SonarCloud Coverage](https://sonarcloud.io/api/project_badges/measure?project=tspence_csharp-csv-reader&metric=coverage)](https://sonarcloud.io/component_measures?id=tspence_csharp-csv-reader&metric=coverage&view=list)
+[![SonarCloud Bugs](https://sonarcloud.io/api/project_badges/measure?project=tspence_csharp-csv-reader&metric=bugs)](https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=tspence_csharp-csv-reader)
+[![SonarCloud Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=tspence_csharp-csv-reader&metric=vulnerabilities)](https://sonarcloud.io/project/issues?resolved=false&types=VULNERABILITY&id=tspence_csharp-csv-reader)
 
 # CSVFile
 This library is a series of unit tested, thoroughly commented CSV parsing functions which I have developed off and on since 2006. Extremely small and easy to implement; includes unit tests for the majority of odd CSV edge cases. Library supports different delimiters, qualifiers, and embedded newlines. Can read and write from data tables.

src/CSV.cs

@@ -320,30 +320,6 @@ internal static string RemoveByteOrderMarker(string rawString)
             sb.Append(line);
         }
 
-        /// <summary>
-        /// Append an array of objects to a StringBuilder in CSV format
-        /// </summary>
-        /// <param name="sb">The StringBuilder to append</param>
-        /// <param name="row">The list of objects to append</param>
-        /// <param name="settings">The CSV settings to use when exporting this array (Default: CSV)</param>
-#if NET2_0
-        private static void AppendCSVRow(StringBuilder sb, IEnumerable<object> row, CSVSettings settings = null)
-#else
-        private static void AppendCSVRow(this StringBuilder sb, IEnumerable<object> row, CSVSettings settings = null)
-#endif
-        {
-            if (settings == null)
-            {
-                settings = CSVSettings.CSV;
-            }
-
-            var riskyChars = settings.GetRiskyChars();
-            var forceQualifierTypes = settings.GetForceQualifierTypes();
-            var csv = ItemsToCsv(row, settings, riskyChars, forceQualifierTypes);
-            sb.Append(csv);
-            sb.Append(settings.LineSeparator);
-        }
-
         /// <summary>
         /// Internal method to convert a list of things into a CSV line using the specified settings object
         /// 
@@ -394,7 +370,7 @@ internal static string ItemsToCsv(IEnumerable<object> items, CSVSettings setting
                     // Only go character-by-character if necessary
                     if (s.IndexOf(settings.TextQualifier) >= 0)
                     {
-                        foreach (var c in s.ToCharArray())
+                        foreach (var c in s)
                         {
                             // Double up text qualifiers
                             if (c == settings.TextQualifier)

src/CSVSettings.cs

@@ -172,7 +172,7 @@ public char[] GetRiskyChars()
             var riskyChars = new List<char>();
             riskyChars.Add(FieldDelimiter);
             riskyChars.Add(TextQualifier);
-            foreach (var c in LineSeparator.ToCharArray())
+            foreach (var c in LineSeparator)
             {
                 riskyChars.Add(c);
             }