[libterminfo] add a terminfo parser so we can remove the ncurses dependency completely

Author: tstack

.circleci/config.yml

@@ -10,18 +10,18 @@ jobs:
     resource_class: macos.m1.medium.gen1
     steps:
       - checkout
-      - run: brew install pcre2 sqlite ncurses xz zstd libarchive curl autoconf automake libunistring coreutils
+      - run: brew install pcre2 sqlite xz zstd libarchive curl autoconf automake libunistring coreutils
       - run: ./autogen.sh
       - run: >-
           ./configure \
             --prefix=/usr/local \
             --with-libcurl=$(brew --prefix curl) \
             --with-pcre2=$(brew --prefix pcre2) \
             --with-sqlite3=$(brew --prefix sqlite3) \
-            "CPPFLAGS=-I$(brew --prefix ncurses)/include -I$(brew --prefix libunistring)/include" \
+            "CPPFLAGS=-I$(brew --prefix libunistring)/include" \
             "CXXFLAGS=-g2 -O2" \
             'CFLAGS=-O2 -g2' \
-            "LDFLAGS=-L$(brew --prefix ncurses)/lib -L$(brew --prefix xz)/lib -L$(brew --prefix lz4)/lib -L$(brew --prefix zstd)/lib/ -L$(brew --prefix libunistring)/lib/" \
+            "LDFLAGS=-L$(brew --prefix xz)/lib -L$(brew --prefix lz4)/lib -L$(brew --prefix zstd)/lib/ -L$(brew --prefix libunistring)/lib/" \
             --with-libarchive=$(brew --prefix libarchive) \
             || cat config.log
       - run: make -j2 || true

.github/workflows/bins.yml

@@ -156,7 +156,7 @@ jobs:
       - name: checkout
         uses: actions/checkout@v3
       - name: install packages
-        run: brew install pcre2 sqlite ncurses xz zstd lz4 libarchive curl autoconf automake libunistring
+        run: brew install pcre2 sqlite xz zstd lz4 libarchive curl autoconf automake libunistring
       - name: autogen
         run: ./autogen.sh
       - name: configure
@@ -165,10 +165,10 @@ jobs:
             --with-libcurl=/usr \
             --with-pcre2=$(brew --prefix pcre2) \
             --with-sqlite3=$(brew --prefix sqlite3) \
-            "CPPFLAGS=-I$(brew --prefix libunistring)/include -I$(brew --prefix ncurses)/include" \
+            "CPPFLAGS=-I$(brew --prefix libunistring)/include" \
             "CXXFLAGS=-g2 -O2" \
             'CFLAGS=-O2 -g2' \
-            "LDFLAGS=-L$(brew --prefix ncurses)/lib -L$(brew --prefix xz)/lib -L$(brew --prefix zstd)/lib/ -L$(brew --prefix lz4)/lib/ -L$(brew --prefix libunistring)/lib" \
+            "LDFLAGS=-L$(brew --prefix xz)/lib -L$(brew --prefix zstd)/lib/ -L$(brew --prefix lz4)/lib/ -L$(brew --prefix libunistring)/lib" \
             --with-libarchive=$(brew --prefix libarchive) \
             "LIBS=-llzma -lexpat -lzstd -liconv -llz4 -lbz2 -lz -lpcre2-8"
       - name: make
@@ -242,7 +242,6 @@ jobs:
             msys/liblzma-devel
             msys/libsqlite-devel
             msys/libunistring-devel
-            msys/ncurses-devel
             msys/pcre2-devel
             msys/zlib-devel
       - name: "🔧 Generate and configure"
@@ -257,7 +256,7 @@ jobs:
           ../lnav/configure \
                       --enable-static \
                       LDFLAGS="-static" \
-                      CPPFLAGS="-O2 -DNCURSES_STATIC" \
+                      CPPFLAGS="-O2" \
                       CXXFLAGS="-fPIC" \
                       CFLAGS="-fPIC" \
                       LIBS="-larchive -lssh2 -llzma -lexpat -llz4 -lz -lzstd -lssl -lcrypto -liconv -lunistring -lbrotlicommon -lcrypt32" \

.github/workflows/c-cpp.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Update apt
         run: sudo apt-get update
       - name: Install packages
-        run: sudo apt-get install libncursesw5-dev libsqlite3-dev libbz2-dev libcurl4-openssl-dev zlib1g-dev lcov libunistring-dev
+        run: sudo apt-get install libsqlite3-dev libbz2-dev libcurl4-openssl-dev zlib1g-dev lcov libunistring-dev
       - name: install cpp-coveralls
         run: pip install --user cpp-coveralls
       - name: autogen
@@ -72,7 +72,6 @@ jobs:
           autoconf
           g++
           libpcre2-dev
-          libncurses-dev
           libsqlite3-dev
           libbz2-dev
           libcurl4-openssl-dev

.github/workflows/coverity.yml

@@ -33,7 +33,6 @@ jobs:
           autoconf
           g++
           libpcre2-dev
-          libncurses-dev
           libsqlite3-dev
           libbz2-dev
           libcurl4-openssl-dev

.github/workflows/release.yml

@@ -63,7 +63,6 @@ jobs:
           g++
           libpcre2-dev
           libpcre3-dev
-          libncurses-dev
           libsqlite3-dev
           libbz2-dev
           libcurl4-openssl-dev

ARCHITECTURE.md

@@ -91,9 +91,9 @@ implemented in the [log_format_impls.cc](src/log_format_impls.cc) file.
 ## User Interface
 
 The lnav text-user-interface is built on top of
-[ncurses](https://invisible-island.net/ncurses/announce.html).
+[notcurses](https://notcurses.com).
 However, the higher-level functionality of panels, widgets, and such is not
-used.  Instead, the following custom components are built on top of the ncurses
+used.  Instead, the following custom components are built on top of the notcurses
 primitives:
 
 - [view_curses](src/view_curses.hh) - Provides the basics for text roles, which
@@ -108,13 +108,6 @@ primitives:
   displays the logs/plaintext/help is a textview.
 - [statusview_curses](src/state-extension-functions.cc) - Draws the status bars
   at the top and bottom of the TUI.
-- [vt52_curses](src/vt52_curses.hh) - Adapts vt52 escape codes to the ncurses
-  API.
-- [readline_curses](src/readline_curses.hh) - Provides access to the readline
-  library.  The readline code is executed in a child process since readline
-  does not get along with ncurses.  The child process and readline is set to
-  use a vt52 terminal and the vt52_curses view is uses to translate those
-  escape codes to ncurses.
 
 The following diagram shows the underlying components that make up the TUI:
 

README

@@ -20,7 +20,6 @@ The following software packages are required to build/run lnav:
   gcc/clang - A C++14-compatible compiler.
   libpcre2  - The Perl Compatible Regular Expression v2 (PCRE2) library.
   sqlite    - The SQLite database engine.  Version 3.9.0 or higher is required.
-  ncurses   - The ncurses text UI library.
   zlib      - The zlib compression library.
   bz2       - The bzip2 compression library.
   re2c      - The re2c scanner generator.

README.md

@@ -176,7 +176,6 @@ The following software packages are required to build lnav:
 - gcc/clang    - A C++14-compatible compiler.
 - libpcre2     - The Perl Compatible Regular Expression v2 (PCRE2) library.
 - sqlite       - The SQLite database engine.  Version 3.9.0 or higher is required.
-- ncurses      - The ncurses text UI library.
 - zlib         - The zlib compression library.
 - bz2          - The bzip2 compression library.
 - libcurl      - The cURL library for downloading files from URLs.  Version 7.23.0 or higher is required.

appveyor.yml

@@ -7,7 +7,7 @@ environment:
     cygsetup: setup-x86_64.exe
 
 install:
-  - C:\%cygwin%\%cygsetup% -qnNdOX -R C:/%cygwin% -l C:/%cygwin%/var/cache/setup -P libpcre2-devel -P libncurses-devel -P libreadline-devel -P zlib-devel -P libbz2-devel -P libsqlite3-devel -P libcurl-devel -P libarchive-devel
+  - C:\%cygwin%\%cygsetup% -qnNdOX -R C:/%cygwin% -l C:/%cygwin%/var/cache/setup -P libpcre2-devel -P libreadline-devel -P zlib-devel -P libbz2-devel -P libsqlite3-devel -P libcurl-devel -P libarchive-devel
 
 build_script:
   - C:\%cygwin%\bin\sh -lc "uname -a && gcc --version && cd /cygdrive/c/projects/lnav && ./autogen.sh && ./configure && make && strip src/lnav.exe && ldd src/lnav.exe"

configure.ac

@@ -86,24 +86,6 @@ AC_SEARCH_LIBS(backtrace, execinfo)
 AC_SEARCH_LIBS(uc_width, unistring, [], [AC_MSG_ERROR([libunistring required to build])])
 LIBCURL_CHECK_CONFIG([], [7.23.0], [], [AC_MSG_ERROR([libcurl required to build])], [test x"${enable_static}" = x"yes"])
 
-# Sometimes, curses depends on these libraries being linked in...
-AC_ARG_ENABLE([tinfo],
-    AS_HELP_STRING([--disable-tinfo],
-        [Disable linking with tinfo, enabled by default]),
-    [], [enable_tinfo="yes"]
-)
-
-AS_IF([test "x${enable_tinfo}" != "xno"],
-    [dnl
-    AC_MSG_NOTICE([Trying to link with tinfo])
-    AC_SEARCH_LIBS(cur_term, [tinfow tinfo],
-        AC_MSG_NOTICE([Linking with tinfo]),
-        AC_MSG_WARN([libtinfo not found])
-    )
-    ],
-    AC_MSG_NOTICE([Building with tinfo linking disabled])
-)
-
 dnl libgpm is required on some systems where there is a misconfigured ncurses
 dnl and gpm libraries with interdependencies. This check is not required on OS X.
 AS_CASE(["$host_os"],
@@ -145,12 +127,6 @@ AS_IF([test "x$with_system_doctest" != "xyes"], [
 
 LNAV_WITH_JEMALLOC
 
-AX_WITH_CURSES
-
-AS_VAR_IF([ax_cv_curses],[yes],[],
-    AC_MSG_ERROR([requires an X/Open-compatible Curses library with color])dnl
-)
-
 AX_PATH_LIB_ARCHIVE
 AX_CHECK_PCRE2([8], [], [AC_MSG_ERROR([pcre2 is required to build])])
 
@@ -201,9 +177,9 @@ AC_DEFINE([_XOPEN_SOURCE_EXTENDED], [1], [Wide character support for ncurses])
 AS_VAR_SET(ALL_LDFLAGS, "$SQLITE3_LDFLAGS $LIBARCHIVE_LDFLAGS $LIBCURL $LDFLAGS")
 
 AS_VAR_SET(static_lib_list,
-           ["libncurses.a libncursesw.a libsqlite3.a libz.a libtinfo.a libtinfow.a"])
+           ["libsqlite3.a libz.a"])
 AS_VAR_SET(static_lib_list,
-           ["$static_lib_list libpcre2-8.a libncursesw.a libbz2.a"])
+           ["$static_lib_list libpcre2-8.a libbz2.a"])
 AS_VAR_SET(static_lib_list,
            ["$static_lib_list libgpm.a libcurl.a libcrypto.a libssl.a libssh2.a"])
 AS_VAR_SET(static_lib_list,