[timeline] use a background color for timeline bars instead of reverse-video

Author: tstack

NEWS.md

@@ -203,9 +203,9 @@ Features:
   The `:hide-in-timeline` command supports live preview,
   highlighting rows that would be hidden in red.
 * The `timestamp-point-of-reference` log format property
-  has been added to specify the related of the timestamp
+  has been added to specify the relation of the timestamp
   to the operation that the message refers to, either:
-  start or send.  This is used in conjunction with the
+  `start` or `end`.  This is used in conjunction with the
   message duration to determine the time span.
 * The OPID for log messages is now shown in the parser
   details overlay (revealed by pressing `p`) in the

TESTS_ENVIRONMENT.in

@@ -19,6 +19,9 @@ export top_builddir
 builddir=`pwd -P`
 export builddir
 
+top_builddir_abs=`dirname ${builddir}`
+export top_builddir_abs
+
 LNAV_VERSION=`${top_builddir}/src/lnav-test -V`
 export LNAV_VERSION
 
@@ -122,6 +125,7 @@ run_cap_test() {
         -e "s;${LNAV_VERSION};{LNAV_VERSION};g" \
         -e "s;${test_dir};{test_dir};g" \
         -e "s;${builddir};{test_dir};g" \
+        -e "s;${top_builddir_abs};{buildir};g" \
         -e "s;${ROOT_DIR};{root_dir};g" \
         -e "s;${top_srcdir};{top_srcdir};g" \
         -e "s;${top_srcdir_parent};{top_srcdir_parent};g" \
@@ -157,6 +161,7 @@ run_cap_test() {
         -e "s;${test_dir};{test_dir};g" \
         -e "s;${ROOT_DIR};{root_dir};g" \
         -e "s;${builddir};{builddir};g" \
+        -e "s;${top_builddir_abs};{buildir};g" \
         -e "s;${top_srcdir};{top_srcdir};g" \
         -e "s;${TMPDIR};{TMPDIR};g" \
         -e "s;/tmp/;{TMPDIR};g" \

docs/schemas/config-v1.schema.json

@@ -770,6 +770,11 @@
                                             "description": "Styling for indent guide lines",
                                             "title": "/ui/theme-defs/<theme_name>/styles/indent-guide",
                                             "$ref": "#/definitions/style"
+                                        },
+                                        "timeline-bar": {
+                                            "description": "Styling for timeline duration bars",
+                                            "title": "/ui/theme-defs/<theme_name>/styles/timeline-bar",
+                                            "$ref": "#/definitions/style"
                                         }
                                     },
                                     "additionalProperties": false

src/base/lnav.console.cc

@@ -454,6 +454,9 @@ role_to_style(const role_t role,
         case role_t::VCR_H6:
             line_style |= fmt::emphasis::underline;
             break;
+        case role_t::VCR_TABLE_HEADER:
+            line_style |= fmt::emphasis::bold;
+            break;
         case role_t::VCR_LIST_GLYPH:
             line_style |= fmt::fg(fmt::terminal_color::yellow);
             break;
@@ -478,6 +481,9 @@ role_to_style(const role_t role,
         case role_t::VCR_SPECTRO_THRESHOLD6:
             line_style |= fmt::bg(fmt::terminal_color::red);
             break;
+        case role_t::VCR_TIMELINE_BAR:
+            line_style |= fmt::bg(fmt::terminal_color::magenta);
+            break;
         default:
             // log_debug("missing role handler %d", (int) role);
             break;

src/base/string_attr_type.hh

@@ -195,6 +195,8 @@ enum class role_t : int32_t {
     VCR_SPECTRO_THRESHOLD5,
     VCR_SPECTRO_THRESHOLD6,
 
+    VCR_TIMELINE_BAR,
+
     VCR__MAX
 };
 

src/db_sub_source.cc

@@ -1308,9 +1308,9 @@ db_overlay_source::list_static_overlay(const listview_curses& lv,
 
     line_range lr(0);
 
+    sa.emplace_back(lr, VC_ROLE.value(role_t::VCR_TABLE_HEADER));
     sa.emplace_back(
         lr,
-        VC_STYLE.value(text_attrs::with_styles(text_attrs::style::bold,
-                                               text_attrs::style::underline)));
+        VC_STYLE.value(text_attrs::with_styles(text_attrs::style::underline)));
     return true;
 }

src/lnav.cc

@@ -645,6 +645,13 @@ make it easier to navigate through files quickly.
         .append("Paths"_h2)
         .append("\n ")
         .append("\u2022"_list_glyph)
+        .append(" This binary:\n")
+        .append("    ")
+        .append(":compass:"_emoji)
+        .append(" ")
+        .append(lnav::roles::file(lnav::filesystem::self_path().value_or("/")))
+        .append("\n ")
+        .append("\u2022"_list_glyph)
         .append(" Format files are read from:")
         .append("\n    ")
         .append(":open_file_folder:"_emoji)

src/lnav_config.cc

@@ -966,6 +966,10 @@ static const struct json_path_container theme_styles_handlers = {
         .with_description("Styling for indent guide lines")
         .for_child(&lnav_theme::lt_style_indent_guide)
         .with_children(style_config_handlers),
+    yajlpp::property_handler("timeline-bar")
+        .with_description("Styling for timeline duration bars")
+        .for_child(&lnav_theme::lt_style_timeline_bar)
+        .with_children(style_config_handlers),
 };
 
 static const struct json_path_container theme_syntax_styles_handlers = {

src/styling.hh

@@ -195,6 +195,7 @@ struct lnav_theme {
     positioned_property<style_config> lt_style_footnote_text;
     positioned_property<style_config> lt_style_snippet_border;
     positioned_property<style_config> lt_style_indent_guide;
+    positioned_property<style_config> lt_style_timeline_bar;
     std::map<log_level_t, positioned_property<style_config>> lt_level_styles;
     std::map<std::string, highlighter_config> lt_highlights;
 };

src/themes/default-theme.json

@@ -150,6 +150,9 @@
                         "color": "Black",
                         "background-color": "Silver"
                     },
+                    "timeline-bar": {
+                        "background-color": "Teal"
+                    },
                     "focused": {
                         "color": "Black",
                         "background-color": "Silver"