do not startup if files are not found

Author: tstack

src/base/fs_util.cc

@@ -206,14 +206,14 @@ determine_path_type(const std::string& arg)
         return path_type::url;
     }
 
-    switch (arg.find(':')) {
-        case 0:
-            return path_type::normal;
-        case 1:
-            return path_type::windows;
-        default:
-            return path_type::remote;
+    const auto colon_pos = arg.find(':');
+    if (colon_pos == std::string::npos) {
+        return path_type::normal;
+    }
+    if (colon_pos == 1) {
+        return path_type::windows;
     }
+    return path_type::remote;
 }
 
 path_transcoder

test/expected/Makefile.am

@@ -8,6 +8,8 @@ dist_noinst_DATA = \
     test_cli.sh_0b3639753916f71254e8c9cce4ebb8bfd9978d3e.out \
     test_cli.sh_10c33e465ef7681c6b5519d05d557426b26cd43d.err \
     test_cli.sh_10c33e465ef7681c6b5519d05d557426b26cd43d.out \
+    test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.err \
+    test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.out \
     test_cli.sh_17a68b798354f9a6cdfab372006caeb74038d15c.err \
     test_cli.sh_17a68b798354f9a6cdfab372006caeb74038d15c.out \
     test_cli.sh_1ec76eb2416d2c09c13eba62ff8bcf920a888b9c.err \

test/expected/test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.err

@@ -0,0 +1,5 @@
+✘ error: unable to open file: badfilename
+ reason: No such file or directory
+✘ error: unable to display interactive text UI
+ reason: stdout is not a TTY
+ = help: pass the -n option to run lnav in headless mode or don't redirect stdout

test/expected/test_cli.sh_1507a515f62dfc9ad0af85decadbd7921be9b96d.out

@@ -5,6 +5,8 @@ export YES_COLOR=1
 
 run_cap_test ${lnav_test} -h
 
+run_cap_test ${lnav_test} badfilename
+
 run_cap_test ${lnav_test} -n -c 'foo'
 
 run_cap_test ${lnav_test} -d /tmp/lnav.err -n <<EOF