[attr_line] always hide SA_REPLACED ranges

Author: tstack

src/base/attr_line.cc

@@ -715,12 +715,12 @@ attr_line_t::nearest_text(size_t x) const
 }
 
 void
-attr_line_t::apply_hide()
+attr_line_t::apply_hide(bool enabled)
 {
     auto& sa = this->al_attrs;
 
     for (auto& sattr : sa) {
-        if (sattr.sa_type == &SA_HIDDEN) {
+        if (enabled && sattr.sa_type == &SA_HIDDEN) {
             auto icon = sattr.sa_value.get<ui_icon_t>();
             auto& lr = sattr.sa_range;
 

src/base/attr_line.hh

@@ -703,7 +703,7 @@ public:
 
     attr_line_t& wrap_with(text_wrap_settings* tws);
 
-    void apply_hide();
+    void apply_hide(bool enabled);
 
     attr_line_t& highlight_fuzzy_matches(const std::string& pattern);
 

src/textview_curses.cc

@@ -936,9 +936,7 @@ textview_curses::textview_value_for_row(vis_line_t row, attr_line_t& value_out)
         this->apply_highlights(value_out, body, orig_line);
     }
 
-    if (this->tc_hide_fields) {
-        value_out.apply_hide();
-    }
+    value_out.apply_hide(this->tc_hide_fields);
 
     const auto& user_marks = this->tc_bookmarks[&BM_USER];
     const auto& user_expr_marks = this->tc_bookmarks[&BM_USER_EXPR];

src/view_helpers.cc

@@ -460,9 +460,7 @@ open_pretty_view()
                 require_ge(al.al_string.length(), orig_lr.lr_end);
             }
             scrub_ansi_string(al.get_string(), &al.get_attrs());
-            if (log_tc->get_hide_fields()) {
-                al.apply_hide();
-            }
+            al.apply_hide(log_tc->get_hide_fields());
 
             const auto orig_lr
                 = find_string_attr_range(al.get_attrs(), &SA_ORIGINAL_LINE);