[windows] convert a windows glob to posix

Author: tstack

src/base/fs_util.cc

@@ -55,6 +55,18 @@
 
 namespace lnav::filesystem {
 
+std::string
+escape_glob_for_win(std::string arg)
+{
+#if defined(__MSYS__)
+    std::replace(arg.begin(), arg.end(), '\\', '/');
+    std::replace(arg.begin(), arg.end(), '^', '\\');
+    return arg;
+#else
+    return arg;
+#endif
+}
+
 std::optional<std::filesystem::path>
 self_path()
 {

src/base/fs_util.hh

@@ -60,6 +60,8 @@ is_glob(const std::string& fn)
             || fn.find('[') != std::string::npos);
 }
 
+std::string escape_glob_for_win(std::string arg);
+
 bool is_url(const std::string& fn);
 
 enum class path_type {

src/base/fs_util.tests.cc

@@ -59,6 +59,16 @@ TEST_CASE("fs_util::to_posix_path")
     CHECK("" == pt.pt_path);
 }
 
+#if defined(__MSYS__)
+TEST_CASE("fs_util::escape_glob_for_win")
+{
+    CHECK(R"(c:/abc/def/*.log)"
+          == lnav::filesystem::escape_glob_for_win(R"(c:\abc\def\*.log)"));
+    CHECK(R"(c:/abc/def/\*.log)"
+          == lnav::filesystem::escape_glob_for_win(R"(c:\abc\def\^*.log)"));
+}
+#endif
+
 TEST_CASE("fs_util::build_path")
 {
     auto* old_path = getenv("PATH");

src/cmds.io.cc

@@ -1184,6 +1184,7 @@ com_open(exec_context& ec, std::string cmdline, std::vector<std::string>& args)
             } else if (lnav::filesystem::is_glob(fn_str)) {
                 static_root_mem<glob_t, globfree> gl;
 
+                fn_str = lnav::filesystem::escape_glob_for_win(fn_str);
                 if (glob(fn_str.c_str(), GLOB_NOCHECK, nullptr, gl.inout())
                     == 0)
                 {

src/file_collection.cc

@@ -655,7 +655,12 @@ file_collection::expand_filename(
     }
 
     auto filename_key = loo.loo_filename.empty() ? path : loo.loo_filename;
+#if defined(__MSYS__)
+    auto win_path = lnav::filesystem::escape_glob_for_win(path);
+    auto glob_rc = glob(win_path.c_str(), GLOB_NOCHECK, nullptr, gl.inout());
+#else
     auto glob_rc = glob(path.c_str(), GLOB_NOCHECK, nullptr, gl.inout());
+#endif
     if (glob_rc == 0) {
         if (gl->gl_pathc == 1 /*&& gl.gl_matchc == 0*/) {
             /* It's a pattern that doesn't match any files

src/fstat_vtab.cc

@@ -473,7 +473,12 @@ rcFilter(sqlite3_vtab_cursor* pVtabCursor,
 #endif
 
     log_debug("doing glob %s", pattern);
+#if defined(__MSYS__)
+    auto win_path = lnav::filesystem::escape_glob_for_win(pattern);
+    switch (glob(win_path.c_str(), glob_flags, nullptr, pCur->c_glob.inout())) {
+#else
     switch (glob(pattern, glob_flags, nullptr, pCur->c_glob.inout())) {
+#endif
         case GLOB_NOSPACE:
             pVtabCursor->pVtab->zErrMsg
                 = sqlite3_mprintf("No space to perform glob()");