[listview] fix jumping over very long lines with Page Up#1530
Merged
Conversation
Owner
|
Thanks! I appreciate you providing the script to help with reproduction and the change seems to work. Sorry for the trouble, I don't use word-wrap much, so don't feel the pain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this fixes an issue with jumping over very long lines (that don't even fit on screen) (btw this's a common case in our logs) with "Page Up".
In such cases
rows_availablereturns 1 andshift_amountevaluates to 0, meaning you can't progress towards the top. In the fix I ensured thatrows_availablehas enough value to proceed, which is close to what has been done in "Page Down" code.Note #1: I used this Python script to generate a text file to test on: