Skip to content

✨🐛Add support for pasting and fix onFullfill call on backspace on last element#30

Open
a-tokyo wants to merge 10 commits into
ttdung11t2:masterfrom
a-tokyo:master
Open

✨🐛Add support for pasting and fix onFullfill call on backspace on last element#30
a-tokyo wants to merge 10 commits into
ttdung11t2:masterfrom
a-tokyo:master

Conversation

@a-tokyo

@a-tokyo a-tokyo commented Jun 6, 2018

Copy link
Copy Markdown

Description

Actions

  • added support for pasting by removing max length = 1 on input and spreading the characters to the next fields while taking care not to exceed the limit
  • fixed onFullfill being called when backspacing the last element by checking for the codeLength
  • reduce bundle size significantly by uninstalling lodash and using only the needed parts
  • added .vscode to .gitignore
  • added package-lock.json

Notes

  • VSCode auto prettifies my code according to prettier, if it's inconvenient let me know

@a-tokyo a-tokyo changed the title ✨Add support for pasting 🐛Fix onFullfill call on backspace on last element ✨🐛Add support for pasting and fix onFullfill call on backspace on last element Jun 6, 2018
@a-tokyo

a-tokyo commented Aug 17, 2018

Copy link
Copy Markdown
Author

@retyui Did the requested changes 💪

@a-tokyo

a-tokyo commented Aug 29, 2018

Copy link
Copy Markdown
Author

@retyui Awesome job 🚀 , but how was my PR added there? :D

@nishantWM nishantWM left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Repository owner deleted a comment from a-tokyo May 23, 2019
NiksCode
NiksCode approved these changes Aug 20, 2020
@a-tokyo

a-tokyo commented Oct 13, 2020

Copy link
Copy Markdown
Author

Handled conflicts

@a-tokyo

a-tokyo commented Oct 14, 2020

Copy link
Copy Markdown
Author

@NiksCode @lsabbagh @nishantWM Please let me know if there's anything else I need to do 👍

@csokdara-thefoundry-app

Copy link
Copy Markdown

There is no onCodeChange function defined on line 286

Comment thread components/ConfirmationCodeInput.js
Comment thread components/ConfirmationCodeInput.js Outdated
@a-tokyo

a-tokyo commented Feb 1, 2021

Copy link
Copy Markdown
Author

@csokdara-thefoundry-app handled

@DeniferSantiago

Copy link
Copy Markdown

this has not been implemented yet?

@a-tokyo

a-tokyo commented Apr 22, 2021

Copy link
Copy Markdown
Author

@DeniferSantiago It's been ready for a while, awaiting merge from contributors ✨

@DeniferSantiago

Copy link
Copy Markdown

Too bad, don't you have a fork?

@a-tokyo

a-tokyo commented Apr 22, 2021

Copy link
Copy Markdown
Author

@DeniferSantiago Yes and you can use it from github directly. Replace the version number of react-native-confirmation-code-input with https://github.com/A-Tokyo/react-native-confirmation-code-input in your package.json

@DeniferSantiago

Copy link
Copy Markdown

Thank you

@a-tokyo

a-tokyo commented Apr 22, 2021

Copy link
Copy Markdown
Author

@DeniferSantiago My pleasure

jasonwiener added a commit to jasonwiener/react-native-confirmation-code-input that referenced this pull request Jan 5, 2022
✨🐛Add support for pasting and fix onFullfill call on backspace on last element ttdung11t2#30 from A-Tokyo (ttdung11t2#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants