0.1.235: Firefox web PDF viewer + collapse newlines in selection translation

- Firefox: intercept http(s) .pdf main_frame navigations via blocking
  webRequest and redirect to the bundled pdf.js viewer, so mouseover
  translation works (Firefox's built-in viewer is a privileged page
  extensions can't inject into, bugzilla 1454760). Firefox-only guard;
  Chrome keeps the MV3 embed-swap path. local file:// PDFs are out of
  reach of webRequest and still use the built-in viewer.
- Selection translation: collapse whitespace/newline runs to a single
  space before translating, so a sentence dragged across wrapped lines
  (esp. in the PDF viewer) is translated and read aloud as one sentence
  instead of being split at the line breaks. (review: DeeTho)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: ttop32

doc/description.md

@@ -19,6 +19,9 @@ Mouseover Translate Any Language At Once
 English, Russian, Japanese, Chinese and so on
 
 # Change Log
+- 0.1.235
+  - Firefox: web (http/https) PDFs now open in the extension's own PDF viewer so mouseover translation works, instead of Firefox's built-in viewer which extensions can't add features to (local file:// PDFs still use the built-in viewer)
+  - Selecting text across multiple lines (e.g. a PDF sentence that wraps) no longer splits the sentence at the line breaks: newlines are collapsed to spaces so it is translated and read aloud as one sentence
 - 0.1.234
   - Fix broken menus and pop-ups on sites that use Tippy.js for their own UI (e.g. zulip.com): the extension's tooltip styles no longer leak onto the page's own tooltips
   - Scroll the settings tab bar sideways with the mouse wheel (no more clicking the arrow buttons when tabs overflow)

public/manifest.firefox.json

@@ -11,7 +11,7 @@
         "128": "icons/icon_128.png"
     },
     "content_security_policy": "script-src 'self' 'wasm-unsafe-eval' ;  object-src 'none'",
-    "permissions": ["storage", "tabs", "scripting", "contextMenus", "search", "<all_urls>"],
+    "permissions": ["storage", "tabs", "scripting", "contextMenus", "search", "webRequest", "webRequestBlocking", "<all_urls>"],
 
 
 

src/background.js

@@ -30,6 +30,7 @@ var recentRecord = {};
     addCopyRequestListener(); // listen copy / save context menus and shortcut key
     addTabSwitchEventListener(); // listen tab switch for kill tts
     addPdfFileTabListener(); //listen drag and drop pdf
+    addFirefoxPdfRedirectListener(); //firefox: redirect web pdf to our viewer
     addSearchBarListener(); // listen url search bar for translate omnibox
     addMessageListener(); // listen message from content script for handle translate & tts
   } catch (error) {
@@ -352,6 +353,34 @@ function checkIsLocalPdfUrl(url) {
   return /^(file:\/\/).*(\.pdf)$/.test(url?.toLowerCase());
 }
 
+// Firefox only: its built-in pdf.js viewer is a privileged page we can't inject
+// our tooltip/translation into (bugzilla 1454760, unfixed 7+ yrs). So intercept
+// http(s) PDF navigations BEFORE the built-in viewer loads and redirect them to
+// our own bundled viewer (a normal extension page where the content script
+// runs). Chrome (MV3) can't use blocking webRequest and keeps the embed-swap
+// path in contentScript.detectPDF instead.
+// Limitation: Firefox webRequest can't intercept file:// requests, so local PDFs
+// still open in the built-in viewer.
+function addFirefoxPdfRedirectListener() {
+  if (!util.isFirefox() || !browser.webRequest?.onBeforeRequest) {
+    return;
+  }
+  browser.webRequest.onBeforeRequest.addListener(
+    function (details) {
+      if (setting?.detectPDF === "false") {
+        return {};
+      }
+      // never touch our own viewer (it loads the pdf via ?file=) -> no loop
+      if (details.url.includes("/pdfjs/web/viewer.html")) {
+        return {};
+      }
+      return { redirectUrl: util.getPDFUrl(details.url) };
+    },
+    { urls: ["*://*/*.pdf", "*://*/*.pdf?*"], types: ["main_frame"] },
+    ["blocking"]
+  );
+}
+
 //search bar================================================
 function addSearchBarListener() {
   browser.omnibox.setDefaultSuggestion({

src/contentScript.js

@@ -159,7 +159,13 @@ function stageTooltipTextSelect(event, useEvent = true) {
   ) {
     prevSelected = selectedText;
     selectedText = useEvent ? event?.selectedText : selectedText;
-    stageTooltipText(selectedText, "select");
+    // A sentence dragged across multiple lines (especially in the PDF viewer,
+    // where getSelection() inserts a newline at every line/span boundary) was
+    // sent to the translator split by newlines and came back as two fragments.
+    // Collapse whitespace runs (incl. newlines) to a single space so a wrapped
+    // sentence is translated — and read aloud — as one flowing sentence.
+    var selectText = selectedText?.replace(/\s+/g, " ").trim();
+    stageTooltipText(selectText, "select");
   }
 }
 

src/util/index.js

@@ -571,6 +571,10 @@ function checkFirefox() {
   return navigator.userAgent.toLowerCase().indexOf('firefox') > -1;
 }
 
+export function isFirefox() {
+  return checkFirefox();
+}
+
 function getOffscreenIframe() {
   return document.querySelector('iframe[src="offscreen.html"]');
 }