Skip to content

Commit 79d4f47

Browse files
taglialatagliala
committed
Add compatibility with Select2 4.1
- Uses Bootstrap's `custom-select` implementation for uniformity - Use SVG background image for clear button - Add some lints to improve code readability Ref: https://getbootstrap.com/docs/4.6/components/forms/#select-menu Close: #49
1 parent f80e235 commit 79d4f47

File tree

6 files changed

+162
-235
lines changed

6 files changed

+162
-235
lines changed

‎.stylelintrc‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@
33
"stylelint-config-twbs-bootstrap/scss"
44
],
55
"rules": {
6-
"selector-class-pattern": "^[a-z][a-z0-9\\-_]*[a-z0-9]$"
6+
"block-closing-brace-empty-line-before": "never",
7+
"declaration-no-important": null,
8+
"rule-empty-line-before": ["always", {
9+
"except": ["first-nested"],
10+
"ignore": ["after-comment"]
11+
}],
12+
"selector-class-pattern": "^[a-z][a-z0-9\\-_]*[a-z0-9]$",
13+
"selector-no-qualifying-type": null
714
}
815
}

‎dist/select2-bootstrap4.css‎

Lines changed: 57 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,20 @@
1818

1919
.select2-container--bootstrap4 .select2-selection {
2020
width: 100%;
21+
min-height: calc(1.5em + 0.75rem + 2px);
22+
padding: 0.375rem 1.75rem 0.375rem 0.75rem;
23+
font-size: 1rem;
24+
font-weight: 400;
25+
line-height: 1.5;
26+
color: #495057;
27+
vertical-align: middle;
2128
background-color: #fff;
2229
border: 1px solid #ced4da;
2330
border-radius: 0.25rem;
24-
-webkit-transition: border-color 0.15s ease-in-out, -webkit-box-shadow 0.15s ease-in-out;
25-
transition: border-color 0.15s ease-in-out, -webkit-box-shadow 0.15s ease-in-out;
26-
transition: border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out;
27-
transition: border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out, -webkit-box-shadow 0.15s ease-in-out; }
31+
-webkit-transition: background-color 0.15s ease-in-out, border-color 0.15s ease-in-out, -webkit-box-shadow 0.15s ease-in-out;
32+
transition: background-color 0.15s ease-in-out, border-color 0.15s ease-in-out, -webkit-box-shadow 0.15s ease-in-out;
33+
transition: background-color 0.15s ease-in-out, border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out;
34+
transition: background-color 0.15s ease-in-out, border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out, -webkit-box-shadow 0.15s ease-in-out; }
2835
@media (prefers-reduced-motion: reduce) {
2936
.select2-container--bootstrap4 .select2-selection {
3037
-webkit-transition: none;
@@ -35,11 +42,6 @@
3542
-webkit-box-shadow: 0 0 0 0.2rem rgba(0, 123, 255, 0.25);
3643
box-shadow: 0 0 0 0.2rem rgba(0, 123, 255, 0.25); }
3744

38-
.select2-container--bootstrap4.select2-container--focus.select2-container--open .select2-selection {
39-
border-bottom: none;
40-
border-bottom-right-radius: 0;
41-
border-bottom-left-radius: 0; }
42-
4345
.select2-container--bootstrap4.select2-container--open.select2-container--above .select2-selection {
4446
border-top-left-radius: 0;
4547
border-top-right-radius: 0; }
@@ -66,18 +68,13 @@ select.is-valid ~ .select2-container--bootstrap4 .select2-selection,
6668
form.was-validated select:valid ~ .select2-container--bootstrap4 .select2-selection {
6769
border-color: #28a745; }
6870

69-
.select2-container--bootstrap4 .select2-search {
70-
width: 100%; }
71-
7271
.select2-container--bootstrap4 .select2-dropdown {
7372
border-color: #ced4da;
7473
border-radius: 0; }
7574
.select2-container--bootstrap4 .select2-dropdown.select2-dropdown--below {
76-
border-top: none;
7775
border-bottom-right-radius: 0.25rem;
7876
border-bottom-left-radius: 0.25rem; }
7977
.select2-container--bootstrap4 .select2-dropdown.select2-dropdown--above {
80-
border-top: 1px solid #ced4da;
8178
border-top-left-radius: 0.25rem;
8279
border-top-right-radius: 0.25rem; }
8380
.select2-container--bootstrap4 .select2-dropdown .select2-results__option[aria-selected="true"] {
@@ -108,42 +105,26 @@ form.was-validated select:valid ~ .select2-container--bootstrap4 .select2-select
108105

109106
.select2-container--bootstrap4 .select2-selection__clear {
110107
float: right;
111-
width: .9em;
112-
height: .9em;
113-
padding-left: .15em;
114-
margin-top: .7em;
115-
margin-right: .3em;
116-
line-height: .75em;
117-
color: #f8f9fa;
118-
background-color: #c8c8c8;
108+
width: 1em;
109+
height: 1em;
110+
padding: 0;
111+
margin: 0.25em 0 0;
112+
font-weight: 700;
113+
line-height: 0.75em;
114+
color: #495057;
115+
background: #e6e6e6 url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' width='10' height='10' viewBox='0 0 16 16'%3e%3cpath fill='%23495057' d='M1 12l4-4-4-4 3-3 4 4 4-4 3 3-4 4 4 4-3 3-4-4-4 4z'/%3e%3c/svg%3e") center no-repeat !important;
119116
border-radius: 100%; }
117+
.select2-container--bootstrap4 .select2-selection__clear span {
118+
display: none; }
120119
.select2-container--bootstrap4 .select2-selection__clear:hover {
121-
background-color: #afafaf; }
120+
background-color: #d9d9d9 !important; }
122121

123122
.select2-container--bootstrap4 .select2-selection--single {
124-
height: calc(1.5em + 0.75rem + 2px) !important; }
123+
background: #fff url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' width='4' height='5' viewBox='0 0 4 5'%3e%3cpath fill='%23343a40' d='M2 0L0 2h4zm0 5L0 3h4z'/%3e%3c/svg%3e") right 0.75rem center/8px 10px no-repeat; }
125124
.select2-container--bootstrap4 .select2-selection--single .select2-selection__placeholder {
126-
line-height: calc(1.5em + 0.75rem);
127125
color: #6c757d; }
128-
.select2-container--bootstrap4 .select2-selection--single .select2-selection__arrow {
129-
position: absolute;
130-
top: 50%;
131-
right: 3px;
132-
width: 20px; }
133-
.select2-container--bootstrap4 .select2-selection--single .select2-selection__arrow b {
134-
position: absolute;
135-
top: 60%;
136-
left: 50%;
137-
width: 0;
138-
height: 0;
139-
margin-top: -2px;
140-
margin-left: -4px;
141-
border-color: #343a40 transparent transparent transparent;
142-
border-style: solid;
143-
border-width: 5px 4px 0; }
144126
.select2-container--bootstrap4 .select2-selection--single .select2-selection__rendered {
145-
padding-left: 0.75rem;
146-
line-height: calc(1.5em + 0.75rem);
127+
padding: 0;
147128
color: #495057; }
148129

149130
.select2-search--dropdown .select2-search__field {
@@ -155,44 +136,49 @@ form.was-validated select:valid ~ .select2-container--bootstrap4 .select2-select
155136
color: #6c757d; }
156137

157138
.select2-container--bootstrap4 .select2-selection--multiple {
158-
min-height: calc(1.5em + 0.75rem + 2px) !important; }
139+
padding: 0 0.75rem; }
159140
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__rendered {
160-
-webkit-box-sizing: border-box;
161-
box-sizing: border-box;
162-
width: 100%;
163-
padding: 0 0.375rem;
164-
margin: 0;
165-
list-style: none; }
141+
margin: 0; }
142+
.select2-container--bootstrap4 .select2-selection--multiple .select2-search--inline {
143+
display: inline-block; }
166144
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__choice {
167-
float: left;
168-
padding: 0;
169-
padding-right: 0.75rem;
170-
margin-top: calc(0.375rem - 2px);
171-
margin-right: 0.375rem;
172-
color: #495057;
145+
position: relative;
146+
display: inline-block;
147+
padding: 0 5px 0 21px;
148+
margin: 0.375rem 0.375rem 0.375rem 0;
149+
color: #fff;
150+
vertical-align: top;
173151
cursor: pointer;
174-
border: 1px solid #bdc6d0;
152+
background-color: #6c757d;
175153
border-radius: 0.2rem; }
154+
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__choice__display {
155+
padding: 0 5px; }
176156
.select2-container--bootstrap4 .select2-selection--multiple .select2-search__field {
157+
height: calc(1.5em + 0.75rem);
158+
padding-top: 0.375rem;
159+
margin: 0;
160+
line-height: 1.5;
177161
color: #495057; }
178-
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__choice + .select2-search {
179-
width: 0; }
180162
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__choice__remove {
181-
float: left;
182-
padding-right: 3px;
183-
padding-left: 3px;
184-
margin-right: 1px;
185-
margin-left: 3px;
163+
position: absolute;
164+
top: 0;
165+
left: 0;
166+
padding: 0 5px;
167+
margin: 0;
186168
font-weight: 700;
187-
color: #bdc6d0; }
169+
color: rgba(255, 255, 255, 0.75);
170+
cursor: pointer;
171+
background: none;
172+
border: none;
173+
border-right: 1px solid #a1a8ae; }
188174
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__choice__remove:hover {
189-
color: #343a40; }
175+
color: rgba(255, 255, 255, 0.85); }
176+
.select2-container--bootstrap4 .select2-selection--multiple.select2-selection--clearable {
177+
padding-right: 32px; }
190178
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__clear {
191-
position: absolute !important;
192-
top: 0;
193-
right: .7em;
194-
float: none;
195-
margin-right: 0; }
179+
position: absolute;
180+
top: 0.375rem;
181+
right: 0.75rem; }
196182

197183
.select2-container--bootstrap4.select2-container--disabled .select2-selection--multiple .select2-selection__choice {
198184
padding: 0 5px;

‎docs/index.html‎

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,6 @@ <h3>Example of <a href="https://github.com/ttskch/select2-bootstrap4-theme" targ
2323
<hr>
2424

2525
<form>
26-
<div class="form-group">
27-
<label>Reference select</label>
28-
<select class="custom-select">
29-
<option value="" hidden="hidden">Choose one thing</option>
30-
<option>1</option>
31-
<option>2</option>
32-
<option>3</option>
33-
<option>4</option>
34-
<option>5</option>
35-
</select>
36-
</div>
37-
3826
<div class="form-group">
3927
<label>Example of select</label>
4028
<select data-placeholder="Choose one thing" data-allow-clear="1">
@@ -47,16 +35,6 @@ <h3>Example of <a href="https://github.com/ttskch/select2-bootstrap4-theme" targ
4735
</select>
4836
</div>
4937

50-
<div class="form-group">
51-
<label>Example of select (pre-selected)</label>
52-
<select data-placeholder="Choose one thing" data-allow-clear="1">
53-
<option></option>
54-
<option selected="selected">1</option>
55-
<option>2</option>
56-
<option>3</option>
57-
</select>
58-
</div>
59-
6038
<div class="form-group">
6139
<label>Example of multiple select</label>
6240
<select multiple data-placeholder="Choose anything" data-allow-clear="1">
@@ -83,41 +61,6 @@ <h3>Example of <a href="https://github.com/ttskch/select2-bootstrap4-theme" targ
8361
</select>
8462
</div>
8563

86-
<div class="form-group">
87-
<label>Example of multiple select (pre-selected)</label>
88-
<select multiple data-placeholder="Choose anything" data-allow-clear="1">
89-
<option selected="selected">Tommy Yount</option>
90-
<option>Hye Panter</option>
91-
<option>Vi Yohe</option>
92-
</select>
93-
</div>
94-
95-
<div class="form-group">
96-
<label>Example of multiple select (many pre-selected)</label>
97-
<select multiple data-placeholder="Choose anything" data-allow-clear="1">
98-
<option selected="selected">Tommy Yount</option>
99-
<option selected="selected">Hye Panter</option>
100-
<option selected="selected">Vi Yohe</option>
101-
<option selected="selected">Keva Bandy</option>
102-
<option selected="selected">Hannelore Corning</option>
103-
<option selected="selected">Delorse Whitcher</option>
104-
<option selected="selected">Katharyn Marrinan</option>
105-
<option selected="selected">Jeannine Tope</option>
106-
<option selected="selected">Jamila Braggs</option>
107-
<option selected="selected">Eden Cunniff</option>
108-
<option selected="selected">Suzy Schoen</option>
109-
<option selected="selected">Elza Mccook</option>
110-
<option selected="selected">Liana Goris</option>
111-
<option selected="selected">Pauletta Schlabach</option>
112-
<option selected="selected">Synthia Dupuis</option>
113-
<option selected="selected">Scarlett Kestler</option>
114-
<option selected="selected">Magdalen Mele</option>
115-
<option selected="selected">Susanna Schenk</option>
116-
<option selected="selected">Else Stupka</option>
117-
<option selected="selected">Pennie Khang</option>
118-
</select>
119-
</div>
120-
12164
<div class="form-group">
12265
<label>Example of disabled select</label>
12366
<select disabled data-placeholder="Cannot choose" data-allow-clear="1">

0 commit comments

Comments
 (0)