Add code-token VisualRoles, Code view, theme palettes, and Markdown highlighting fixes by Copilot · Pull Request #5313 · tui-cs/Terminal.Gui

Copilot · 2026-05-15T18:38:51Z

Fixes

Adds shared, theme-driven code-token visual roles for syntax-highlighted content across Markdown, the new Code view, UICatalog samples, and downstream editor scenarios. Fixes code-block highlighting for MarkdownTester by preserving explicitly configured Base code-token roles in derived Accent schemes.

Proposed Changes/Todos

Added VisualRole.CodeComment through VisualRole.CodeAttribute with Scheme storage, JSON round-trip support, and fallback behavior.
Added Default/Base and bundled theme Code/Code* palettes, preserving 8-Bit monochrome behavior.
Updated Markdown and MarkdownCodeBlock rendering to resolve TextMate-highlighted tokens through VisualRole.Code*.
Added the public Code view for syntax-highlighted code display.
Added UICatalog demos and design-time samples that exercise every code visual role.
Shared the code-role legend highlighter between Code.EnableForDesign and CodeViewDemo to avoid duplicated marker logic.
Fixed MarkdownTester code-block highlighting when using the derived Accent scheme.
Updated DeriveAccent so only explicitly set Base code-token roles are copied into Accent schemes.
Added/updated tests for scheme derivation, JSON conversion, TextMate scope mapping, Markdown rendering, code-token background inheritance, Code rendering, and design-time role coverage.

Pull Request checklist:

I've named my PR in the form of "Fixes #issue. Terse description."
My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
My code follows the Terminal.Gui library design guidelines
I ran dotnet test before commit
I have made corresponding changes to the API documentation (using /// style comments)
My changes generate no new warnings
I have checked my code and corrected any poor grammar or misspellings
I conducted basic QA to assure all features are working

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/87c31cb1-c209-40bb-a480-6f3fbe9e8d55 Co-authored-by: tig <585482+tig@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb8c1f7be6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/716ef4d6-34b7-4e16-a9ca-7494cf2d3d03 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot · 2026-05-16T22:45:05Z

@copilot see CR feedback. Plus, as this shows, syntax coloring is not working at least with the Default theme:

<img width="352" height="250" alt="image" src="https://github.com/user-attachments/ass...

Fixed in 45ac4fc. Default now gets an explicit Code* palette, and Code View Demo now lays the code panel below the full theme selector so all themes are visible. I captured an updated UI screenshot during validation at /tmp/tg-ui-review/code-demo.png.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

accounts.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4978 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.Ej6kUJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,2725822441057920996,1310311505937363881,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,1145042349965070522,16301931831828469840,4 --trace-process-track-uuid=3190708989122997041 (dns block)
- Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/tg-ui-review/code-demo.png --window-size=1000,560 file:///tmp/tg-ui-review/code-demo.html (dns block)
clients2.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4978 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.Ej6kUJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,2725822441057920996,1310311505937363881,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,1145042349965070522,16301931831828469840,4 --trace-process-track-uuid=3190708989122997041 (dns block)
- Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/tg-ui-review/code-demo.png --window-size=1000,560 file:///tmp/tg-ui-review/code-demo.html (dns block)
redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4978 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.Ej6kUJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,2725822441057920996,1310311505937363881,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,1145042349965070522,16301931831828469840,4 --trace-process-track-uuid=3190708989122997041 (dns block)
- Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/tg-ui-review/code-demo.png --window-size=1000,560 file:///tmp/tg-ui-review/code-demo.html (dns block)
www.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4978 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.Ej6kUJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,2725822441057920996,1310311505937363881,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,1145042349965070522,16301931831828469840,4 --trace-process-track-uuid=3190708989122997041 (dns block)
- Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/tg-ui-review/code-demo.png --window-size=1000,560 file:///tmp/tg-ui-review/code-demo.html (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/ef7d2993-1886-4dde-8edf-00c3e179b2e7 Co-authored-by: tig <585482+tig@users.noreply.github.com>

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

Copilot · 2026-05-16T23:13:05Z

@copilot

Only Default and 8-bit (because it's supposed to be b&w) Themes look correct.
...

Fixed in a5e4751. Added Code/Code* palettes for the non-Default built-in and UICatalog themes, kept 8-Bit monochrome, and made token backgrounds inherit the Code background so Dark/Light/etc. render consistently. Updated screenshot captured at /tmp/tg-ui-review/code-demo-themes.svg.

tig · 2026-05-16T23:15:11Z

@copilot make the Code.EnableForDesign include code that shows every code visualstyle. Same for all the examples in the CodeViewDemo scenario.

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/d40d66b5-826e-4e91-9c78-882d18e58b6c Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot · 2026-05-16T23:25:15Z

@copilot make the Code.EnableForDesign include code that shows every code visualstyle. Same for all the examples in the CodeViewDemo scenario.

Fixed in 07aeabe. Code.EnableForDesign and each Code View Demo sample now include a visible role legend that exercises every Code visual role. Updated screenshot captured at /tmp/tg-ui-review/code-demo-role-samples.svg.

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

DeriveAccent now copies every Code* attribute from baseScheme (resolved via GetAttributeForRole) into the accent scheme as explicitly set values. Because GetAttributeForRole walks the derivation chain, even unset code-token roles on the base scheme become explicit on the accent. This means: (a) accent schemes will report TryGetExplicitlySetAttributeForRole(VisualRole.CodeXxx) as true even though the original theme didn't set them, and (b) future changes to baseScheme's Code attribute will no longer propagate to the accent's code tokens because the accent now pins concrete copies. Consider only copying values that were explicitly set on the base scheme (using TryGetExplicitlySetAttributeForRole) so derivation continues to work. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/89b866c3-6b09-44f6-b2b0-e4f10515d475 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Phase 2 of specs/syntax-theme/spec.md. Routes the xshd highlighter through Terminal.Gui's Scheme/VisualRole machinery so themes drive syntax colors and the editor background follows the active scheme (fixes #128; restores #99's theme story via ThemeManager). - XshdRoleMap: xshd <Color name> -> VisualRole.Code* bridge table (spec 6.2) - HighlightingColor.Role + xshd category= override (XshdColor/V2Loader/ XmlHighlightingDefinition/SaveXshdVisitor); logged in UPSTREAM.md - HighlightingColorizer.ToAttribute resolves: explicit scheme role -> xshd foreground over scheme bg -> default; ctor takes role-lookup funcs - Removed Editor.UseThemeBackground end-to-end (theme decides bg now) - Editor repaints on ThemeManager.ThemeChanged - ted: status-bar Theme shortcut cycles ThemeManager.Theme - Tests: scheme-role / xshd-fallback / XshdRoleMap coverage / category override (unit) + scheme-swap render smoke (integration). 439 + 174 green. Blocked on tui-cs/Terminal.Gui#5313 (code-token VisualRoles) reaching a published develop pre-release. <TerminalGuiVersion> must be bumped to that build before CI can go green; verified locally against a #5313 pack via -p:TerminalGuiVersion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

tui-cs/Terminal.Gui#5313 (code-token VisualRoles) is published on the develop NuGet feed as 2.1.1-develop.95 (later .125-.163 are bad/unlisted). Bumped <TerminalGuiVersion> off the placeholder and removed the TODO. Verified against the real published package: build 0 warnings/0 errors, Tests 439/439, IntegrationTests 190/190, dotnet format clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Initial plan

615d6ff

Copilot AI assigned Copilot and tig May 15, 2026

Copilot started work on behalf of tig May 15, 2026 18:38 View session

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request

Add code-token VisualRole vocabulary (CodeComment/CodeKeyword/etc.); add Code view; unify markdown highlighter #5311

Closed

10 tasks

Add code token visual roles

fb8c1f7

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/87c31cb1-c209-40bb-a480-6f3fbe9e8d55 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add code-token VisualRole vocabulary and unify markdown highlighter~~ Add code-token VisualRoles and Code view May 15, 2026

Copilot finished work on behalf of tig May 15, 2026 18:54

Copilot AI requested a review from tig May 15, 2026 18:54

tig marked this pull request as ready for review May 16, 2026 22:31

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread Terminal.Gui/Drawing/Markdown/MarkdownAttributeHelper.cs Outdated

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of tig May 16, 2026 22:40 View session

Fix default code view coloring

45ac4fc

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/716ef4d6-34b7-4e16-a9ca-7494cf2d3d03 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 16, 2026 22:45

Merge branch 'copilot/add-code-token-visualrole-vocabulary' of https:…

dc05426

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of tig May 16, 2026 23:00 View session

tig and others added 3 commits May 16, 2026 16:07

Code cleanup.

a87b3c1

Fix code colors across themes

a5e4751

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/ef7d2993-1886-4dde-8edf-00c3e179b2e7 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Merge branch 'copilot/add-code-token-visualrole-vocabulary' of https:…

ba602b8

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

Copilot AI changed the title ~~Add code-token VisualRoles and Code view~~ Add code-token VisualRoles, Code view, and theme palettes May 16, 2026

Copilot finished work on behalf of tig May 16, 2026 23:13

Copilot started work on behalf of tig May 16, 2026 23:15 View session

Show all code visual roles in samples

07aeabe

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/d40d66b5-826e-4e91-9c78-882d18e58b6c Co-authored-by: tig <585482+tig@users.noreply.github.com>

Merge branch 'copilot/add-code-token-visualrole-vocabulary' of https:…

8520dd8

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

Copilot started work on behalf of tig May 16, 2026 23:48 View session

tig and others added 3 commits May 16, 2026 16:49

Refactor code role legend highlighter

86631a7

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/89b866c3-6b09-44f6-b2b0-e4f10515d475 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Fix accent scheme code role copy

e98c01d

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/89b866c3-6b09-44f6-b2b0-e4f10515d475 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 16, 2026 23:57

This was referenced May 17, 2026

[#132] Wire xshd colorizer through TG Scheme code-token VisualRoles tui-cs/Editor#134

Merged

Wire xshd colorizer through TG Scheme code-token VisualRoles (theme/palette layer) tui-cs/Editor#132

Closed

BDisp approved these changes May 17, 2026

View reviewed changes

YourRobotOverlord approved these changes May 17, 2026

View reviewed changes

tig added 2 commits May 16, 2026 21:21

Merge branch 'copilot/add-code-token-visualrole-vocabulary' of https:…

336531a

…//github.com/gui-cs/Terminal.Gui into copilot/add-code-token-visualrole-vocabulary

fixed xml doc warning

f426b06

tig merged commit cec8623 into develop May 17, 2026
13 checks passed

tig deleted the copilot/add-code-token-visualrole-vocabulary branch May 17, 2026 04:43

This was referenced Jun 15, 2026

Bump Terminal.Gui from 2.0.1 to 2.4.6 sgrassie/BlogHelper9000#135

Closed

Bump Terminal.Gui from 1.19.0 to 2.4.6 jas88/RDMP#233

Closed

dependabot Bot mentioned this pull request Jun 22, 2026

Bump Terminal.Gui from 1.19.0 to 2.4.11 jas88/RDMP#236

Closed

This was referenced Jun 29, 2026

Bump Terminal.Gui from 1.19.0 to 2.4.16 jas88/RDMP#242

Open

Bump the dotnet-dependencies group with 13 updates jntm7/pitterm#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add code-token VisualRoles, Code view, theme palettes, and Markdown highlighting fixes#5313

Add code-token VisualRoles, Code view, theme palettes, and Markdown highlighting fixes#5313
tig merged 16 commits into
developfrom
copilot/add-code-token-visualrole-vocabulary

Copilot AI commented May 15, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Copilot AI commented May 16, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

This comment was marked as outdated.

Copilot AI commented May 16, 2026

Uh oh!

tig commented May 16, 2026

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Copilot AI commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes

Proposed Changes/Todos

Pull Request checklist:

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

This comment was marked as outdated.

Copilot AI commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

This comment was marked as outdated.

Copilot AI commented May 16, 2026

Uh oh!

tig commented May 16, 2026

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented May 15, 2026 •

edited

Loading

Copilot AI commented May 16, 2026 •

edited

Loading