Release v2.4.17#5580
Conversation
Back-merge v2.4.16 from main into develop
--- updated-dependencies: - dependency-name: Microsoft.Extensions.Options dependency-version: 10.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: GitVersion.MsBuild dependency-version: 6.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ild-6.8.0 Bump GitVersion.MsBuild from 6.7.0 to 6.8.0
…sions.Options-10.0.9 Bump Microsoft.Extensions.Options from 10.0.7 to 10.0.9
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76dfb25911
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| internal class FileDialogState | ||
| { | ||
| private static readonly EnumerationOptions _ignoreInaccessibleEnumerationOptions = new () { IgnoreInaccessible = true }; |
There was a problem hiding this comment.
In directories containing hidden/system entries (including dotfiles on Unix), this new EnumerationOptions instance keeps the framework default AttributesToSkip value of Hidden | System. Because the file dialog now passes these options to EnumerateDirectories/EnumerateFileSystemInfos, those entries are filtered out before they can be displayed or searched, whereas the previous GetDirectories()/GetFileSystemInfos() calls listed them. Set AttributesToSkip = 0 while enabling IgnoreInaccessible to preserve the existing FileDialog behavior.
Useful? React with 👍 / 👎.
…Inaccessible change (#5581) The switch to EnumerateDirectories/EnumerateFileSystemInfos with EnumerationOptions { IgnoreInaccessible = true } (from the #5544 follow-up) kept the framework default AttributesToSkip = Hidden | System, so the file dialog silently filtered out hidden/system entries — including dotfiles on Unix, which .NET marks as Hidden. The GetDirectories ()/GetFileSystemInfos () calls it replaced never skipped them. - Clear AttributesToSkip (FileAttributes.None) so hidden/system entries stay visible while still ignoring inaccessible ones. - Fall back to the eager listing methods when the IFileSystem implementation throws NotSupportedException for the non-default AttributesToSkip (e.g. System.IO.Abstractions.TestingHelpers MockFileSystem). - Add regression tests covering the enumeration options, the fallback, and hidden/system files via MockFileSystem. Flagged by Codex review on #5580. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
Release v2.4.17
Version:
2.4.17NuGet Package:
Terminal.Gui 2.4.17What happens when this PR is merged
v2.4.17main→developwill be openedChecklist
2.4.17