Skip to content

Add dismiss delegate methods#38

Open
danqing wants to merge 1 commit intotungvoduc:masterfrom
danqing:master
Open

Add dismiss delegate methods#38
danqing wants to merge 1 commit intotungvoduc:masterfrom
danqing:master

Conversation

@danqing
Copy link
Copy Markdown

@danqing danqing commented Mar 9, 2020

I'd like to get notified when the viewer is dismissed interactively. Currently there's no way to get notified.

The reason I need it is I'm playing video in the photo viewer, and I want to stop it when the viewer is dismissed.

@tungvoduc
Copy link
Copy Markdown
Owner

@danqing I think you can easily achieve that by subclassing DTPhotoViewerController and override method dismiss(animated:, completion:). I am not sure if delegate methods is necessary.

@danqing
Copy link
Copy Markdown
Author

danqing commented Mar 9, 2020

How should I override that method? I want to be notified when the viewer is dismissed and I feel like a delegate method is the best way to do it. Is there any downside of adding a new delegate method?

@danqing
Copy link
Copy Markdown
Author

danqing commented Sep 5, 2021

Hi @tungvoduc — it's been a while. Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants