FDW companion changes for Config API path#642
Draft
Abhi011999 wants to merge 1 commit intoturbot:developfrom
Draft
FDW companion changes for Config API path#642Abhi011999 wants to merge 1 commit intoturbot:developfrom
Abhi011999 wants to merge 1 commit intoturbot:developfrom
Conversation
Abhi011999
force-pushed
the
feat/config-api
branch
from
e0d50bd to
4d1335d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main issue tracked here: turbot/steampipe#4949
Why this FDW change is needed
FDW previously depended on broad config reload behavior (
LoadConnectionConfig) in query planning paths to discover new/updated connections. That is incompatible with the Config API fast path where connection updates are intended to be active synchronously without relying on blanket disk-backed reloads.This PR removes blanket per-query reload and keeps FDW behavior compatible by resolving connection/plugin state through plugin-manager runtime state when
GlobalConfigmetadata is unavailable.Known limitation
For API-only connections where aggregator metadata is not available in
GlobalConfig, aggregator fanout can degrade to single-connection execution until metadata is refreshed/populated. Eliminating this fully requires explicit runtime metadata channel/RPC from plugin manager (connection type and resolved children), which is separate scope.