libsql: Remove redundant variable mutability

Author: penberg

libsql/benches/benchmark.rs

@@ -93,7 +93,7 @@ fn bench(c: &mut Criterion) {
     group.bench_function("in-memory-select-1-prepared", |b| {
         b.to_async(&rt).iter_batched(
             || block_on(conn.prepare("SELECT 1")).unwrap(),
-            |mut stmt| async move {
+            |stmt| async move {
                 let mut rows = stmt.query(()).await.unwrap();
                 let row = rows.next().await.unwrap().unwrap();
                 assert_eq!(row.get::<i32>(0).unwrap(), 1);
@@ -113,7 +113,7 @@ fn bench(c: &mut Criterion) {
     group.bench_function("in-memory-select-star-from-users-limit-1-unprepared", |b| {
         b.to_async(&rt).iter_batched(
             || block_on(conn.prepare("SELECT * FROM users LIMIT 1")).unwrap(),
-            |mut stmt| async move {
+            |stmt| async move {
                 let mut rows = stmt.query(()).await.unwrap();
                 let row = rows.next().await.unwrap().unwrap();
                 assert_eq!(row.get::<i32>(0).unwrap(), 1);
@@ -128,7 +128,7 @@ fn bench(c: &mut Criterion) {
         |b| {
             b.to_async(&rt).iter_batched(
                 || block_on(conn.prepare("SELECT * FROM users LIMIT 100")).unwrap(),
-                |mut stmt| async move {
+                |stmt| async move {
                     let mut rows = stmt.query(()).await.unwrap();
                     let row = rows.next().await.unwrap().unwrap();
                     assert_eq!(row.get::<i32>(0).unwrap(), 1);
@@ -156,7 +156,7 @@ fn bench(c: &mut Criterion) {
     group.bench_function("local-replica-select-1-prepared", |b| {
         b.to_async(&rt).iter_batched(
             || block_on(conn.prepare("SELECT 1")).unwrap(),
-            |mut stmt| async move {
+            |stmt| async move {
                 let mut rows = stmt.query(()).await.unwrap();
                 let row = rows.next().await.unwrap().unwrap();
                 assert_eq!(row.get::<i32>(0).unwrap(), 1);
@@ -188,7 +188,7 @@ fn bench(c: &mut Criterion) {
         |b| {
             b.to_async(&rt).iter_batched(
                 || block_on(conn.prepare("SELECT * FROM users LIMIT 1")).unwrap(),
-                |mut stmt| async move {
+                |stmt| async move {
                     let mut rows = stmt.query(()).await.unwrap();
                     let row = rows.next().await.unwrap().unwrap();
                     assert_eq!(row.get::<i32>(0).unwrap(), 1);
@@ -204,7 +204,7 @@ fn bench(c: &mut Criterion) {
         |b| {
             b.to_async(&rt).iter_batched(
                 || block_on(conn.prepare("SELECT * FROM users LIMIT 100")).unwrap(),
-                |mut stmt| async move {
+                |stmt| async move {
                     let mut rows = stmt.query(()).await.unwrap();
                     let row = rows.next().await.unwrap().unwrap();
                     assert_eq!(row.get::<i32>(0).unwrap(), 1);

libsql/examples/deserialization.rs

@@ -22,15 +22,15 @@ async fn main() {
     .await
     .unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("INSERT INTO users (name, age, vision, avatar) VALUES (?1, ?2, ?3, ?4)")
         .await
         .unwrap();
     stmt.execute(("Ferris the Crab", 8, -6.5, vec![1, 2, 3]))
         .await
         .unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("SELECT * FROM users WHERE name = ?1")
         .await
         .unwrap();

libsql/examples/example.rs

@@ -21,14 +21,14 @@ async fn main() {
         .await
         .unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("INSERT INTO users (email) VALUES (?1)")
         .await
         .unwrap();
 
     stmt.execute(["foo@example.com"]).await.unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("SELECT * FROM users WHERE email = ?1")
         .await
         .unwrap();

libsql/examples/example_v2.rs

@@ -21,14 +21,14 @@ async fn main() {
         .await
         .unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("INSERT INTO users (email) VALUES (?1)")
         .await
         .unwrap();
 
     stmt.execute(["foo@example.com"]).await.unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("SELECT * FROM users WHERE email = ?1")
         .await
         .unwrap();

libsql/examples/flutter.rs

@@ -30,14 +30,14 @@ async fn main() {
         .await
         .unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("INSERT INTO users (email) VALUES (?1)")
         .await
         .unwrap();
 
     stmt.execute(["foo@example.com"]).await.unwrap();
 
-    let mut stmt = conn
+    let stmt = conn
         .prepare("SELECT * FROM users WHERE email = ?1")
         .await
         .unwrap();

libsql/src/wasm/mod.rs

@@ -100,7 +100,7 @@ where
 
     pub async fn query(&self, sql: &str, params: impl IntoParams) -> crate::Result<Rows> {
         tracing::trace!("querying `{}`", sql);
-        let mut stmt = crate::hrana::Statement::new(
+        let stmt = crate::hrana::Statement::new(
             self.conn.current_stream().clone(),
             sql.to_string(),
             true,
@@ -139,7 +139,7 @@ where
     pub async fn query(&self, sql: &str, params: impl IntoParams) -> crate::Result<Rows> {
         tracing::trace!("querying `{}`", sql);
         let stream = self.inner.stream().clone();
-        let mut stmt = crate::hrana::Statement::new(stream, sql.to_string(), true).await?;
+        let stmt = crate::hrana::Statement::new(stream, sql.to_string(), true).await?;
         let rows = stmt.query_raw(&params.into_params()?).await?;
         Ok(Rows {
             inner: Box::new(rows),

libsql/tests/integration_tests.rs

@@ -600,7 +600,7 @@ async fn debug_print_row() {
     .await
     .unwrap();
 
-    let mut stmt = conn.prepare("SELECT * FROM users").await.unwrap();
+    let stmt = conn.prepare("SELECT * FROM users").await.unwrap();
     let mut rows = stmt.query(()).await.unwrap();
     assert_eq!(
         format!("{:?}", rows.next().await.unwrap().unwrap()),