feature to move checkpoint callback if any frames is written#2054
Merged
feature to move checkpoint callback if any frames is written#2054
Conversation
Currently we report a checkpoint is finished only when `mxSafeFrame == mxFrame` in wal it is useful to have finish callback to be triggered in case any work moving frames was accomplished. bundled changes with new flag
pereman2
force-pushed
the
checkpoint-any-frame
branch
from
8a30810 to
0c3b93a
Compare
sivukhin
approved these changes
May 8, 2025
pereman2
force-pushed
the
checkpoint-any-frame
branch
2 times, most recently
from
1452664 to
0c3b93a
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 14, 2025
Replace `libsql-checkpoint-callback-on-any-frame-written` feature (introduced in #2054) with `libsql-checkpoint-only-full` which will force checkpoint to either abort immediately or transfer whole WAL file to the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we report a checkpoint is finished only when
mxSafeFrame == mxFramein walit is useful to have finish callback to be triggered in case any work moving frames was accomplished.