Conversation
sivukhin
approved these changes
Aug 26, 2025
If we fail to read the metadata file, we must return an error. Resetting the metadata leads to inconsistent state because you have no way to tell what the database represents.
If server returns zero as generation, lets return an error from get_remote_info() instead of making metadata inconsistent.
penberg
force-pushed
the
fix-metadata-handling
branch
from
630c55f to
4d9247b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix metadata handling to ensure that we don't have inconsistent metadata locally.