Skip to content

Fix bootstrap case when we treat absent metadata as metadata with gen=0 #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penberg merged 1 commit into from
Sep 2, 2025
Merged

Fix bootstrap case when we treat absent metadata as metadata with gen=0 #2154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions libsql/src/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,6 @@ impl SyncContext {
remote_encryption,
};
me.read_metadata().await?;
if me.durable_generation == 0 {
return Err(SyncError::InvalidLocalState("generation is 0".to_string()).into());
}
Ok(me)
}

Expand Down Expand Up @@ -575,6 +572,10 @@ impl SyncContext {
metadata
);

if metadata.generation == 0 {
return Err(SyncError::InvalidLocalState("generation is 0".to_string()).into());
}

self.durable_generation = metadata.generation;
self.durable_frame_num = metadata.durable_frame_num;

Expand Down Expand Up @@ -991,7 +992,8 @@ pub async fn try_pull(
if !insert_handle.in_session() {
tracing::debug!(
"pull_frames: generation={}, frame={}, start wal transaction session",
generation, next_frame_no
generation,
next_frame_no
);
insert_handle.begin()?;
}
Expand Down
Loading