818: Use proper id comparison

Author: Lakoja

app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsViewModel.kt

@@ -41,6 +41,7 @@ import com.keylesspalace.tusky.settings.PrefKeys
 import com.keylesspalace.tusky.usecase.TimelineCases
 import com.keylesspalace.tusky.util.StatusDisplayOptions
 import com.keylesspalace.tusky.util.deserialize
+import com.keylesspalace.tusky.util.isLessThan
 import com.keylesspalace.tusky.util.serialize
 import com.keylesspalace.tusky.util.throttleFirst
 import com.keylesspalace.tusky.util.toViewData
@@ -567,7 +568,7 @@ class NotificationsViewModel @Inject constructor(
 
         val highestNotificationId = trackerArray[statusId]
 
-        return if (highestNotificationId == null || isEqualOrNewer(notificationId, highestNotificationId)) {
+        return if (highestNotificationId == null || highestNotificationId.isLessThan(notificationId)) {
             trackerArray[statusId] = notificationId
 
             true
@@ -580,19 +581,6 @@ class NotificationsViewModel @Inject constructor(
         }
     }
 
-    /**
-     * NOTE this currently assumes that the ids are integers. Can that change? If it does all notifications are unequal.
-     */
-    fun isEqualOrNewer(thisId: String, idToCompare: String): Boolean {
-        try {
-            return thisId.toInt() >= idToCompare.toInt()
-        } catch (exc: NumberFormatException) {
-            Log.e(TAG, "Cannot compare ids; not numbers: "+thisId+"/"+idToCompare)
-
-            return false
-        }
-    }
-
     /**
      * @return Flow of relevant preferences that change the UI
      */