Skip to content

Fix resource leaks #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clayton-shopify wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix resource leaks #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/capybara/apparition/driver/chrome_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def initialize(ws_url)

def stop
@ws.close
@events.push(nil)
end

def on(event_name, session_id = nil, &block)
Expand Down Expand Up @@ -159,6 +160,7 @@ def read_msg

def cleanup_async_responses
loop do
break if [:closing, :closed].include?(@ws.driver.state)
@msg_mutex.synchronize do
@message_available.wait(@msg_mutex, 0.1)
(@responses.keys & @async_ids).each do |msg_id|
Expand All @@ -173,6 +175,7 @@ def cleanup_async_responses
def process_messages
# run handlers in own thread so as not to hang message processing
loop do
break if [:closing, :closed].include?(@ws.driver.state)
event = @events.pop
next unless event

Expand Down