Skip to content

Support Brave browser #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madhums wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Brave browser #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b57a7
Support Brave browser
madhums Jul 13, 2022
e863a7e
add brave support for linux and windows too
madhums Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/capybara/apparition/browser/launcher/local.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def path

def windows_path
envs = %w[LOCALAPPDATA PROGRAMFILES PROGRAMFILES(X86)]
directories = %w[\\Google\\Chrome\\Application \\Chromium\\Application]
directories = %w[\\Google\\Chrome\\Application \\Chromium\\Application \\BraveSoftware]
files = %w[chrome.exe]

directories.product(envs, files).lazy.map { |(dir, env, file)| "#{ENV[env]}\\#{dir}\\#{file}" }
Expand All @@ -143,14 +143,15 @@ def windows_path
def macosx_path
directories = ['', File.expand_path('~')]
files = ['/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
'/Applications/Chromium.app/Contents/MacOS/Chromium']
'/Applications/Chromium.app/Contents/MacOS/Chromium',
'/Applications/Brave Browser.app/Contents/MacOS/Brave Browser']
directories.product(files).map(&:join).find { |f| File.exist?(f) } ||
find_first_binary('Google Chrome', 'Chromium')
find_first_binary('Google Chrome', 'Chromium', 'Brave Browser')
end

def linux_path
directories = %w[/usr/local/sbin /usr/local/bin /usr/sbin /usr/bin /sbin /bin /opt/google/chrome]
files = %w[google-chrome chrome chromium chromium-browser]
files = %w[google-chrome chrome chromium chromium-browser brave-browser]

directories.product(files).map { |p| p.join('/') }.find { |f| File.exist?(f) } ||
find_first_binary(*files)
Expand Down