Skip to content

Commit 7ac6644

Browse files
authored
Update control CSS vars (#42113)
* Update input vars to be control vars * Update radio, check, and switch to use new control vars * bump bundle
1 parent 36ff500 commit 7ac6644

14 files changed

Lines changed: 101 additions & 96 deletions

File tree

.bundlewatch.config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
},
2727
{
2828
"path": "./dist/css/bootstrap.css",
29-
"maxSize": "40.75 kB"
29+
"maxSize": "41.0 kB"
3030
},
3131
{
3232
"path": "./dist/css/bootstrap.min.css",

scss/_root.scss

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,14 @@ $root-tokens: defaults(
102102
// scss-docs-end root-focus-variables
103103

104104
// scss-docs-start root-form-variables
105-
--input-bg: var(--bg-body),
106-
--input-color: var(--fg-body),
105+
--control-bg: var(--bg-body),
106+
--control-fg: var(--fg-body),
107+
--control-checked-bg: var(--primary-base),
108+
--control-checked-border-color: var(--control-checked-bg),
109+
--control-active-bg: var(--primary-base),
110+
--control-active-border-color: var(--control-active-bg),
111+
--control-disabled-bg: var(--bg-3),
112+
--control-disabled-opacity: .65,
107113

108114
--btn-input-min-height: 2.375rem,
109115
--btn-input-padding-y: .375rem,

scss/forms/_check.scss

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,25 @@ $check-tokens: () !default;
1717
// stylelint-disable-next-line scss/dollar-variable-default
1818
$check-tokens: defaults(
1919
(
20+
--check-size: 1rem,
2021
--check-bg: transparent,
2122
--check-border-color: var(--border-color),
22-
--check-checked-bg: var(--primary-base),
23-
--check-checked-border-color: var(--primary-base),
24-
--check-indeterminate-bg: var(--primary-base),
25-
--check-indeterminate-border-color: var(--primary-base),
26-
--check-disabled-bg: var(--bg-3),
27-
--check-disabled-opacity: .65,
23+
--check-checked-bg: var(--control-checked-bg),
24+
--check-checked-border-color: var(--control-checked-border-color),
25+
--check-indeterminate-bg: var(--control-checked-bg),
26+
--check-indeterminate-border-color: var(--control-checked-border-color),
27+
--check-active-bg: var(--control-active-bg),
28+
--check-active-border-color: var(--control-active-border-color),
29+
--check-disabled-bg: var(--control-disabled-bg),
30+
--check-disabled-opacity: var(--control-disabled-opacity),
2831
),
2932
$check-tokens
3033
);
3134
// scss-docs-end check-tokens
3235
// stylelint-enable custom-property-no-missing-var-function
3336

3437
@layer forms {
35-
b-checkgroup {
38+
.checkgroup {
3639
display: flex;
3740
gap: var(--gap, .5rem);
3841
align-items: var(--align-items, start);
@@ -53,8 +56,8 @@ $check-tokens: defaults(
5356
flex-shrink: 0;
5457
grid-row-start: 1;
5558
grid-column-start: 1;
56-
width: 1rem;
57-
height: 1rem;
59+
width: var(--check-size);
60+
height: var(--check-size);
5861
}
5962

6063
:where(input) {
@@ -63,7 +66,7 @@ $check-tokens: defaults(
6366
background-color: var(--theme-bg, var(--check-bg));
6467
border: 1px solid var(--theme-bg, var(--check-border-color));
6568
// stylelint-disable-next-line property-disallowed-list
66-
border-radius: .25em;
69+
border-radius: .3em;
6770
}
6871

6972
:where(input:checked, input:indeterminate) {
@@ -78,15 +81,15 @@ $check-tokens: defaults(
7881
&:has(input:checked) .checked,
7982
&:has(input:indeterminate) .indeterminate {
8083
display: block;
81-
color: var(--primary-contrast);
84+
color: var(--theme-contrast, var(--primary-contrast));
8285
stroke: currentcolor;
8386
}
8487

8588
&:has(input:disabled) {
8689
--check-bg: var(--check-disabled-bg);
8790

8891
~ label {
89-
color: var(--secondary-text);
92+
color: var(--fg-3);
9093
cursor: default;
9194
}
9295
}

scss/forms/_chip-input.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ $chip-input-tokens: defaults(
6767
opacity: 1;
6868

6969
> .chip {
70-
opacity: .65;
70+
opacity: var(--control-disabled-opacity);
7171

7272
.chip-dismiss {
7373
pointer-events: none;

scss/forms/_floating-labels.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ $form-floating-tokens: defaults(
105105
z-index: -1;
106106
height: var(--form-floating-label-height);
107107
content: "";
108-
background-color: var(--input-bg);
108+
background-color: var(--control-bg);
109109
@include border-radius(var(--btn-input-border-radius));
110110
}
111111
}

scss/forms/_form-control.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ $form-control-tokens: defaults(
2424
--control-padding-x: var(--btn-input-padding-x),
2525
--control-font-size: var(--btn-input-font-size),
2626
--control-line-height: var(--btn-input-line-height),
27-
--control-color: var(--input-color),
28-
--control-bg: var(--input-bg),
27+
--control-color: var(--control-fg),
28+
--control-bg: var(--control-bg),
2929
--control-border-width: var(--border-width),
3030
--control-border-color: var(--border-color),
3131
--control-border-radius: var(--border-radius),

scss/forms/_radio.scss

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,21 @@ $radio-tokens: () !default;
1717
// stylelint-disable-next-line scss/dollar-variable-default
1818
$radio-tokens: defaults(
1919
(
20+
--radio-size: 1rem,
2021
--radio-bg: transparent,
2122
--radio-border-color: var(--border-color),
22-
--radio-checked-bg: var(--primary-base),
23-
--radio-checked-border-color: var(--primary-base),
24-
--radio-disabled-bg: var(--bg-3),
25-
--radio-disabled-opacity: .65,
23+
--radio-checked-bg: var(--control-checked-bg),
24+
--radio-checked-border-color: var(--control-checked-border-color),
25+
--radio-disabled-bg: var(--control-disabled-bg),
26+
--radio-disabled-opacity: var(--control-disabled-opacity),
2627
),
2728
$radio-tokens
2829
);
2930
// scss-docs-end radio-tokens
3031
// stylelint-enable custom-property-no-missing-var-function
3132

3233
@layer forms {
33-
b-radiogroup {
34+
.radiogroup {
3435
display: flex;
3536
gap: var(--gap, .5rem);
3637
align-items: var(--align-items, start);
@@ -45,8 +46,8 @@ $radio-tokens: defaults(
4546

4647
position: relative;
4748
flex-shrink: 0;
48-
width: 1rem;
49-
height: 1rem;
49+
width: var(--radio-size);
50+
height: var(--radio-size);
5051
margin-block: .125rem;
5152
appearance: none;
5253
background-color: var(--theme-bg, var(--radio-bg));

scss/forms/_switch.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ $switch-tokens: defaults(
2525
--switch-border-width: var(--border-width),
2626
--switch-border-color: var(--border-color),
2727
--switch-indicator-bg: var(--white),
28-
--switch-checked-bg: var(--primary-base),
28+
--switch-checked-bg: var(--control-checked-bg),
2929
--switch-checked-border-color: var(--switch-checked-bg),
3030
--switch-checked-indicator-bg: var(--white),
31-
--switch-disabled-bg: var(--bg-3),
31+
--switch-disabled-bg: var(--control-disabled-bg),
3232
--switch-disabled-indicator-bg: var(--fg-3),
3333
),
3434
$switch-tokens
@@ -62,7 +62,7 @@ $switch-tokens: defaults(
6262
width: calc(var(--switch-height) - calc(var(--switch-padding) * 2) - var(--switch-border-width) * 2);
6363
height: calc(var(--switch-height) - calc(var(--switch-padding) * 2) - var(--switch-border-width) * 2);
6464
content: "";
65-
background-color: var(--switch-indicator-bg);
65+
background-color: var(--theme-contrast, var(--switch-indicator-bg));
6666
// stylelint-disable-next-line property-disallowed-list
6767
border-radius: 50%;
6868
box-shadow: 0 1px 2px rgba($black, .1);

site/src/components/shortcodes/StepperPlayground.astro

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ const stepCounts = [3, 4, 5, 6]
132132

133133
<div class="vstack gap-1">
134134
<label class="form-label fw-semibold mb-0 user-select-none">&nbsp;</label>
135-
<b-checkgroup class="py-2">
135+
<div class="checkgroup py-2">
136136
<div class="switch">
137137
<input type="checkbox" value="" id="stepper-fullwidth" role="switch" switch>
138138
</div>
139139
<label for="stepper-fullwidth">Full width</label>
140-
</b-checkgroup>
140+
</div>
141141
</div>
142142
</div>
143143
</div>

site/src/content/docs/components/dropdown.mdx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,16 +273,16 @@ Put a form within a dropdown menu, or make it into a dropdown menu, and use [mar
273273
<label for="exampleDropdownFormPassword1" class="form-label">Password</label>
274274
<input type="password" class="form-control" id="exampleDropdownFormPassword1" placeholder="Password">
275275
</div>
276-
<b-checkgroup>
276+
<div class="checkgroup">
277277
<div class="check">
278278
<input type="checkbox" id="checkLabel" />
279-
<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 20 20'>
280-
<path class="checked" fill='none' stroke='currentcolor' stroke-linecap='round' stroke-linejoin='round' stroke-width='3' d='m6 10 3 3 6-6'/>
281-
<path class="indeterminate" fill='none' stroke='currentcolor' stroke-linecap='round' stroke-linejoin='round' stroke-width='3' d='M6 10h8'/>
279+
<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 16 16'>
280+
<path class="checked" fill='none' stroke='currentcolor' stroke-linecap='round' stroke-linejoin='round' stroke-width='3' d='m4 8 3 3 5-5'/>
281+
<path class="indeterminate" fill='none' stroke='currentcolor' stroke-linecap='round' stroke-linejoin='round' stroke-width='3' d='M5 8h6'/>
282282
</svg>
283283
</div>
284284
<label for="checkLabel">Example new checkbox</label>
285-
</b-checkgroup>
285+
</div>
286286
<div class="vstack gap-2">
287287
<button type="submit" class="btn-solid theme-primary">Sign in</button>
288288
<a class="btn-ghost theme-secondary" href="#">New around here? Sign up</a>

0 commit comments

Comments
 (0)