Skip to content

Allow customizable breakpoints for navbars#36521

Closed
pine3ree wants to merge 5 commits into
twbs:mainfrom
pine3ree:patch-7
Closed

Allow customizable breakpoints for navbars#36521
pine3ree wants to merge 5 commits into
twbs:mainfrom
pine3ree:patch-7

Conversation

@pine3ree

@pine3ree pine3ree commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

We usually do not need so many breakpoints for navbars as for grids: see #36517 for feature description.

@pine3ree pine3ree requested a review from a team as a code owner June 7, 2022 13:08
Comment thread scss/_variables.scss Outdated
Comment thread scss/_variables.scss

// Navbar

// scss-docs-start navbar-variables

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be restored.

Comment thread scss/_maps.scss
$theme-colors-rgb: map-loop($theme-colors, to-rgb, "$value") !default;
// scss-docs-end theme-colors-rgb

// scss-docs-start navbar-breakpoints

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document this on the navbar page as well?

@pine3ree

Copy link
Copy Markdown
Contributor Author

Closed in favor of #38909

@pine3ree pine3ree closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Needs review

Development

Successfully merging this pull request may close these issues.

3 participants