Skip to content

Allow customizable breakpoints for navbars #36521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pine3ree wants to merge 5 commits into from
Closed

Allow customizable breakpoints for navbars #36521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
934314e
Add separate $navbar-breakpoints
pine3ree Jun 7, 2022
46df3e6
use $navbar-breakpoints
pine3ree Jun 7, 2022
cd71d05
move $navbar-breakpoints definition into _maps.scss
pine3ree Jun 9, 2022
41fd544
$navbar-breakpoints def moved into _maps.scss
pine3ree Jun 9, 2022
856653a
Merge branch 'main' into patch-7
julien-deramond Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scss/_maps.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
$theme-colors-rgb: map-loop($theme-colors, to-rgb, "$value") !default;
// scss-docs-end theme-colors-rgb

// scss-docs-start navbar-breakpoints

@mdo mdo Oct 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document this on the navbar page as well?

$navbar-breakpoints: $grid-breakpoints !default;
// scss-docs-end navbar-breakpoints

// Utilities maps
//
// Extends the default `$theme-colors` maps to help create our utilities.
Expand Down
2 changes: 1 addition & 1 deletion scss/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
// Generate series of `.navbar-expand-*` responsive classes for configuring
// where your navbar collapses.
.navbar-expand {
@each $breakpoint in map-keys($grid-breakpoints) {
@each $breakpoint in map-keys($navbar-breakpoints) {
$next: breakpoint-next($breakpoint, $grid-breakpoints);
$infix: breakpoint-infix($next, $grid-breakpoints);

Expand Down
1 change: 0 additions & 1 deletion scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,6 @@ $nav-pills-link-active-bg: $component-active-bg !default;

// Navbar

// scss-docs-start navbar-variables

@mdo mdo Oct 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be restored.

$navbar-padding-y: $spacer * .5 !default;
$navbar-padding-x: null !default;

Expand Down