Skip to content

fix: add navbar hover bg variables (#41316)#41372

Closed
Sanchay117 wants to merge 1 commit intotwbs:mainfrom
Sanchay117:navbar-hover-bg-variables-added
Closed

fix: add navbar hover bg variables (#41316)#41372
Sanchay117 wants to merge 1 commit intotwbs:mainfrom
Sanchay117:navbar-hover-bg-variables-added

Conversation

@Sanchay117
Copy link
Copy Markdown

@Sanchay117 Sanchay117 commented Apr 13, 2025

Description

This PR adds two missing SCSS variables for navbar link background colors on hover:

  • $navbar-light-hover-bg
  • $navbar-dark-hover-bg

These variables allow theme authors to customize the background color on hover for light and dark navbars, similar to the already-existing *-hover-color variables.

Motivation & Context

Currently, Bootstrap provides navbar-light-hover-color and navbar-dark-hover-color but lacks corresponding background color variables. This limits customization options and makes it difficult to apply consistent theming via variables. This PR resolves issue #41316.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #41316

@Sanchay117 Sanchay117 requested a review from a team as a code owner April 13, 2025 11:45
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That said, we can't add new Sass variables unless they're actually used somewhere in the codebase—this ensures that any overridden values will take effect.

Also, we haven't yet reviewed the related issue to decide whether these two variables should be included at all. So for now, I'll go ahead and close this PR while we wait on that decision.

@Sanchay117
Copy link
Copy Markdown
Author

Alright, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

navbar hover bg variables are missing

2 participants