fix: add navbar hover bg variables (#41316)#41372
Closed
Sanchay117 wants to merge 1 commit intotwbs:mainfrom
Closed
fix: add navbar hover bg variables (#41316)#41372Sanchay117 wants to merge 1 commit intotwbs:mainfrom
Sanchay117 wants to merge 1 commit intotwbs:mainfrom
Conversation
julien-deramond
requested changes
Apr 14, 2025
Member
julien-deramond
left a comment
There was a problem hiding this comment.
Thanks for the PR! That said, we can't add new Sass variables unless they're actually used somewhere in the codebase—this ensures that any overridden values will take effect.
Also, we haven't yet reviewed the related issue to decide whether these two variables should be included at all. So for now, I'll go ahead and close this PR while we wait on that decision.
Author
|
Alright, thanks for the info! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two missing SCSS variables for navbar link background colors on hover:
$navbar-light-hover-bg$navbar-dark-hover-bgThese variables allow theme authors to customize the background color on hover for light and dark navbars, similar to the already-existing
*-hover-colorvariables.Motivation & Context
Currently, Bootstrap provides
navbar-light-hover-colorandnavbar-dark-hover-colorbut lacks corresponding background color variables. This limits customization options and makes it difficult to apply consistent theming via variables. This PR resolves issue #41316.Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #41316