Skip to content

Docs: Prevent layout shift caused by Carbon ads #41452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PierBover wants to merge 10 commits into from
+19 −8
Closed

Docs: Prevent layout shift caused by Carbon ads #41452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec5e1e2
fix layout shift by carbon ads
PierBover May 7, 2025
02058da
added SCSS var for the .ad-container min-height
PierBover May 7, 2025
0500170
Merge branch 'main' into main
julien-deramond May 7, 2025
3484e29
Increased .ad-container height
PierBover May 8, 2025
9963c70
Merge branch 'main' of https://github.com/PierBover/bootstrap
PierBover May 8, 2025
6411241
Add `hideAdContainerIfEmpty` function
julien-deramond May 23, 2025
5a5a097
Merge branch 'main' into main
julien-deramond May 23, 2025
3c347d2
Update site/src/components/Ads.astro
julien-deramond May 23, 2025
6702a18
Revert idea
julien-deramond May 23, 2025
678c24c
Drop extra empty line
julien-deramond May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions site/src/components/Ads.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
---
---

<script
is:inline
async
src="https://cdn.carbonads.com/carbon.js?serve=CKYIKKJL&placement=getbootstrapcom"
id="_carbonads_js"
></script>
<div class="ad-container overflow-auto">
<script
is:inline
async
src="https://cdn.carbonads.com/carbon.js?serve=CKYIKKJL&placement=getbootstrapcom"
id="_carbonads_js"
></script>
</div>
4 changes: 4 additions & 0 deletions site/src/scss/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@

.bd-intro {
grid-area: intro;

.ad-container {
min-height: $bd-ad-container-height;
}
}

.bd-toc {
Expand Down
8 changes: 6 additions & 2 deletions site/src/scss/_masthead.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@
background-color: transparent;
}

#carbonads { // stylelint-disable-line selector-max-id
margin-inline: auto;
.ad-container {
min-height: $bd-ad-container-height;

#carbonads { // stylelint-disable-line selector-max-id
margin-inline: auto;
}
}

@include media-breakpoint-up(md) {
Expand Down
1 change: 1 addition & 0 deletions site/src/scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ $bd-accent: #ffe484;

$bd-gutter-x: 3rem;
$bd-callout-variants: info, warning, danger !default;
$bd-ad-container-height: 200px;

:root,
[data-bs-theme="light"] {
Expand Down