From 740afcadae530bbef3d0af1b6df263d332a5cfb1 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Fri, 13 Jun 2025 16:47:06 -0400 Subject: [PATCH 1/7] Update README.md: fix localhost port --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ae38dcf7cb75..93083410cb41 100644 --- a/README.md +++ b/README.md @@ -151,7 +151,7 @@ Documentation search is powered by [Algolia's DocSearch](https://docsearch.algol 1. Run `npm install` to install the Node.js dependencies, including Astro (the site builder). 2. Run `npm run test` (or a specific npm script) to rebuild distributed CSS and JavaScript files, as well as our docs assets. 3. From the root `/bootstrap` directory, run `npm run docs-serve` in the command line. -4. Open `http://localhost:9001/` in your browser, and voilà. +4. Open in your browser, and voilà. Learn more about using Astro by reading its [documentation](https://docs.astro.build/en/getting-started/). From e1ea0f42e34c9d41c958e2bf0e73682606d6f671 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Fri, 13 Jun 2025 17:37:14 -0400 Subject: [PATCH 2/7] Restore 9001 as the local-dev port --- README.md | 2 +- package.json | 2 +- site/src/content/docs/getting-started/contribute.mdx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 93083410cb41..d996246bdc28 100644 --- a/README.md +++ b/README.md @@ -151,7 +151,7 @@ Documentation search is powered by [Algolia's DocSearch](https://docsearch.algol 1. Run `npm install` to install the Node.js dependencies, including Astro (the site builder). 2. Run `npm run test` (or a specific npm script) to rebuild distributed CSS and JavaScript files, as well as our docs assets. 3. From the root `/bootstrap` directory, run `npm run docs-serve` in the command line. -4. Open in your browser, and voilà. +4. Open in your browser, and voilà. Learn more about using Astro by reading its [documentation](https://docs.astro.build/en/getting-started/). diff --git a/package.json b/package.json index 648d18e0dbec..aab996c9f205 100644 --- a/package.json +++ b/package.json @@ -81,7 +81,7 @@ "docs-lint": "npm-run-all docs-prettier-check docs-vnu", "docs-prettier-check": "prettier --config site/.prettierrc.json -c --cache site", "docs-prettier-format": "prettier --config site/.prettierrc.json --write --cache site", - "docs-serve": "npm run astro-dev", + "docs-serve": "npm run astro-dev -- --port 9001", "docs-serve-only": "npx sirv-cli _site --port 9001", "lockfile-lint": "lockfile-lint --allowed-hosts npm --allowed-schemes https: --empty-hostname false --type npm --path package-lock.json", "update-deps": "ncu -u -x eslint,eslint-config-xo,eslint-plugin-unicorn,karma-browserstack-launcher,karma-rollup-preprocessor,sass", diff --git a/site/src/content/docs/getting-started/contribute.mdx b/site/src/content/docs/getting-started/contribute.mdx index cf3783dfff11..39793f30effe 100644 --- a/site/src/content/docs/getting-started/contribute.mdx +++ b/site/src/content/docs/getting-started/contribute.mdx @@ -56,7 +56,7 @@ Running our documentation locally requires the use of Astro. Astro is a modern s 1. Run through the [tooling setup](#tooling-setup) above to install all dependencies. 2. From the root `/bootstrap` directory, run `npm run docs-serve` in the command line. -3. Open `http://localhost:4321/` in your browser, and voilà. +3. Open `http://localhost:9001/` in your browser, and voilà. Learn more about using Astro by reading its [documentation](https://docs.astro.build/en/getting-started/). From 7fd9ba337654fd9c501aea1d9d8635b179098082 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Sat, 14 Jun 2025 08:57:36 +0200 Subject: [PATCH 3/7] Modify Astro config to use 9001 port as well --- site/astro.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/astro.config.ts b/site/astro.config.ts index bb79984f2219..400330f4a4cd 100644 --- a/site/astro.config.ts +++ b/site/astro.config.ts @@ -9,7 +9,7 @@ const isDev = process.env.NODE_ENV === 'development' const site = isDev ? // In development mode, use the local dev server. - 'http://localhost:4321' + 'http://localhost:9001' : process.env.DEPLOY_PRIME_URL !== undefined ? // If deploying on Netlify, use the `DEPLOY_PRIME_URL` environment variable. process.env.DEPLOY_PRIME_URL From 2aee6a87f36255d2577bb81b5de980c4a06911d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Sat, 14 Jun 2025 09:25:54 +0200 Subject: [PATCH 4/7] Move 9001 port to npm astro scripts --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index aab996c9f205..7a910005f940 100644 --- a/package.json +++ b/package.json @@ -81,7 +81,7 @@ "docs-lint": "npm-run-all docs-prettier-check docs-vnu", "docs-prettier-check": "prettier --config site/.prettierrc.json -c --cache site", "docs-prettier-format": "prettier --config site/.prettierrc.json --write --cache site", - "docs-serve": "npm run astro-dev -- --port 9001", + "docs-serve": "npm run astro-dev", "docs-serve-only": "npx sirv-cli _site --port 9001", "lockfile-lint": "lockfile-lint --allowed-hosts npm --allowed-schemes https: --empty-hostname false --type npm --path package-lock.json", "update-deps": "ncu -u -x eslint,eslint-config-xo,eslint-plugin-unicorn,karma-browserstack-launcher,karma-rollup-preprocessor,sass", @@ -100,9 +100,9 @@ "watch-css-test": "nodemon --watch scss/ --ext scss,js --exec \"npm run css-test\"", "watch-js-main": "nodemon --watch js/src/ --ext js --exec \"npm-run-all js-lint js-compile\"", "watch-js-docs": "nodemon --watch site/src/assets/ --ext js --exec \"npm run js-lint\"", - "astro-dev": "astro dev --root site", + "astro-dev": "astro dev --root site --port 9001", "astro-build": "astro build --root site && rm -rf _site && cp -r site/dist _site", - "astro-preview": "astro preview --root site" + "astro-preview": "astro preview --root site --port 9001" }, "peerDependencies": { "@popperjs/core": "^2.11.8" From a3b7f455e29b7b8d7fc8c31a94f544b65f922043 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Sat, 14 Jun 2025 09:11:03 -0400 Subject: [PATCH 5/7] Use raw URL in contrib page too --- site/src/content/docs/getting-started/contribute.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/content/docs/getting-started/contribute.mdx b/site/src/content/docs/getting-started/contribute.mdx index 39793f30effe..e1af5dc2934f 100644 --- a/site/src/content/docs/getting-started/contribute.mdx +++ b/site/src/content/docs/getting-started/contribute.mdx @@ -56,7 +56,7 @@ Running our documentation locally requires the use of Astro. Astro is a modern s 1. Run through the [tooling setup](#tooling-setup) above to install all dependencies. 2. From the root `/bootstrap` directory, run `npm run docs-serve` in the command line. -3. Open `http://localhost:9001/` in your browser, and voilà. +3. Open http://localhost:9001 in your browser, and voilà. Learn more about using Astro by reading its [documentation](https://docs.astro.build/en/getting-started/). From 1e995dbd2671c0c35b2f41aab338feaf402a0f35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Mon, 16 Jun 2025 23:39:10 +0200 Subject: [PATCH 6/7] Handle `http://localhost:9001` with linkinator check --- .github/workflows/docs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 8cdf39327909..a437a1c9cb3e 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -47,4 +47,4 @@ jobs: paths: _site recurse: true verbosity: error - skip: "^(?!http://localhost)" + skip: "^(?!http://localhost(:\\d+)?/)" From d9e64b66292336e2a3fdf03ff569ffade2249cfb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Mon, 16 Jun 2025 23:47:17 +0200 Subject: [PATCH 7/7] Handle `http://localhost:9001` with linkinator check (2nd test) --- .github/workflows/docs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index a437a1c9cb3e..d7c88aeb0c60 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -47,4 +47,4 @@ jobs: paths: _site recurse: true verbosity: error - skip: "^(?!http://localhost(:\\d+)?/)" + skip: "^http://localhost"