Skip to content

v6: Update Datepicker and move docs to forms section#42037

Merged
julien-deramond merged 1 commit into
twbs:v6-devfrom
coliff:dev/coliff/datepicker-update
Jan 27, 2026
Merged

v6: Update Datepicker and move docs to forms section#42037
julien-deramond merged 1 commit into
twbs:v6-devfrom
coliff:dev/coliff/datepicker-update

Conversation

@coliff

@coliff coliff commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Description

v6: Update Datepicker and move docs to forms section. Change agreed with @mdo.

Vanilla Calendar Pro update includes some useful bug fixes and accessibility improvements: https://github.com/uvarov-frontend/vanilla-calendar-pro/releases/tag/v3.1.0

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copilot AI review requested due to automatic review settings January 25, 2026 01:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Datepicker component documentation by moving it from the Components section to the Forms section and updates the underlying vanilla-calendar-pro library from v3.0.5 to v3.1.0 for bug fixes and accessibility improvements.

Changes:

  • Relocated Datepicker documentation from components to forms section in the sidebar navigation
  • Updated vanilla-calendar-pro peer dependency from ^3.0.5 to ^3.1.0
  • Added comprehensive new documentation file for Datepicker in the forms section

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
site/src/content/docs/forms/datepicker.mdx New comprehensive documentation for the Datepicker component with examples, options, methods, and events
site/data/sidebar.yml Moved Datepicker entry from Components to Forms section
package.json Updated vanilla-calendar-pro peer dependency to ^3.1.0
package-lock.json Updated resolved version and integrity hash for vanilla-calendar-pro to 3.1.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @coliff, LGTM
I updated the changes in .bundlewatch.config.json as we use .25 step, you couldn't know :)

Note for @mdo: there's a difference between Bundlewatch run here by GitHub Actions, and locally with npm run bundlewatch:table. For instance, 8c65e7a fixed locally, but failed with GitHub Actions.

@coliff

coliff commented Jan 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks Julien! One thing to consider is the ordering of the pages for forms on the sidebar. They are alphabetically listed for components, helpers and utilities sections (which makes sense), but sort of listed in order of importance/complexity for forms section. Not sure where Datepicker is optimally placed here.

@julien-deramond

Copy link
Copy Markdown
Member

One thing to consider is the ordering of the pages for forms on the sidebar. They are alphabetically listed for components, helpers and utilities sections (which makes sense), but sort of listed in order of importance/complexity for forms section. Not sure where Datepicker is optimally placed here.

I’m not entirely sure either. We can revisit this in a follow-up PR once we get Mark’s feedback. One possible approach would be to keep Overview first, then list the remaining pages alphabetically, since they aren’t all components and there isn’t a clear reading order.

@mdo

mdo commented Jan 26, 2026

Copy link
Copy Markdown
Member

Wondering if something funky is happening with our preview deployments—I'm seeing this broken rendering there, but not locally.

CleanShot 2026-01-26 at 10 38 42@2x

@mdo mdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placement looks good for now—forms are a little funky like that. I may update ordering elsewhere too—we need to revisit some of the docs navigation I think at this point, too. Something to think about.

@julien-deramond

Copy link
Copy Markdown
Member

Wondering if something funky is happening with our preview deployments—I'm seeing this broken rendering there, but not locally.
[...]

Good catch. I’m seeing the same issue when running npm run dist locally, so this is likely an upstream bug in version 3.1.0. If you’re both okay with it, I can remove the version bump from this PR and we’ll handle it later.

@coliff

coliff commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

sorry for missing that issue! I can reproduce now.
I'll try and get it fixed and add fix to this PR. Should also move _datepicker.scss to /forms!

@coliff coliff requested a review from a team as a code owner January 27, 2026 01:49
@coliff

coliff commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the issue! Needed to move the grid styles to the new [data-vc-dates="row"] selector.
https://deploy-preview-42037--twbs-bootstrap.netlify.app/docs/5.3/forms/datepicker/#overview

Moving _datepicker.scss to /forms can be done separately I think.

Update Datepicker and move docs to forms section
Update .bundlewatch.config.json
@coliff coliff force-pushed the dev/coliff/datepicker-update branch from 02259df to 4f2ac6b Compare January 27, 2026 04:13
@julien-deramond

Copy link
Copy Markdown
Member

Fixed the issue! Needed to move the grid styles to the new [data-vc-dates="row"] selector.

Neat! Thank you!

Moving _datepicker.scss to /forms can be done separately I think.

Yes, sure.

@julien-deramond julien-deramond merged commit 172f106 into twbs:v6-dev Jan 27, 2026
12 checks passed
@coliff coliff deleted the dev/coliff/datepicker-update branch January 27, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

4 participants