New root defaults for inputs and buttons#42139
Merged
Merged
Conversation
Both the buttons and the inputs are too large for what they're designed for. This PR normalizes the difference between variants by making them more uniform. It also makes it match more closely to BS4, BS5, Tailwind, Catalyst, etc. I don't want to repeat everything that I've wrote in the v6 feedback, so kindly please have a read at: https://github.com/orgs/twbs/discussions/42138 Feel free to decline this PR if you believe the current defaults are fine.
Since line-height is `1.5`, the `-y` padding should have stayed the same at `.375rem` (that totals to `2.25rem` (`36px`) plus the borders, it's `2.375rem` (`38px)).
Author
|
Forgot to mention, this PR would basically achieve what's described here: https://github.com/orgs/twbs/discussions/42090#discussioncomment-15882268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my opinion, both the buttons and the inputs on Bootstrap 6 are too large for what they're intended for.
This PR normalizes the difference between variants by making them more uniform, while also slightly adjusting their height.
It also makes it match more closely to BS4, BS5, Tailwind, Catalyst, etc.
I don't want to repeat everything that I've wrote in the v6 feedback, so kindly please have a read at: https://github.com/orgs/twbs/discussions/42138
Feel free to decline this PR if you believe the current defaults are fine.