Docs: fix Bootstrap bundle loading consistency between dev and static builds#42237
Merged
Conversation
mdo
force-pushed
the
v6-dev-fix-bootstrap-bundle-docs-loading
branch
from
f6a4f43 to
4a7fc84
Compare
Member
|
All pages that I tried look good—JS works as intended! Updated the original comment to also mention that this fixes the live alert and toast demos as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42341, fixes #42340.
Description
In some docs pages, the dropdowns (color modes and versions selector) in the menu are not working, such as https://v6-dev--twbs-bootstrap.netlify.app/docs/6.0/examples/ or https://v6-dev--twbs-bootstrap.netlify.app/docs/6.0/customize/overview/.
The other pages are working because they include a component that is using something from
bootstrap.bundle.*.js, like the<Code>component. If this component is not used, Bootstrap JS is not loaded.Checklist
npm run startfor several pagesnpm run docsandhttp-serverin_sitedir for several pagesWarning
With the current fix, it works locally with
npm run start, but for Netlify it works only for pages where it didn't work before 🙃 Maybe loading it 2 times causes an issue too.Live previews