Tests: fix dialog/drawer dispose-while-open scroll-lock assertions#42575
Merged
Conversation
The dispose-while-open specs added in #42544 asserted the scroll-lock class on document.body, but #42545 moved the lock to the root element (documentElement). The two changes were each green in isolation but broke once both landed on v6-dev. Align these specs with the rest of the suite, which already asserts on documentElement.
bootstrap.bundle.js (83.15KB) and bootstrap.js (54.39KB) now exceed the prior thresholds after the dialog/drawer/tooltip/popover/menu fixes landed; each PR bumped only relative to its own base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispose-while-open specs added in #42544 asserted the
dialog-openscroll-lock class ondocument.body, but #42545 moved the lock to the root element (documentElement). Each PR was green in isolation; together on v6-dev the two stale assertions fail. This aligns the two specs with the rest of the suite, which already asserts ondocumentElement.