feat: add dotnet 10 support#328
Draft
wmundev wants to merge 4 commits into
Draft
Conversation
twcclegg
reviewed
May 9, 2026
Co-authored-by: Thomas Clegg <t@clegg.dev>
# Conflicts: # .github/workflows/run_performance_tests_windows.yml # csharp/PhoneNumbers.Extensions.Test/PhoneNumbers.Extensions.Test.csproj
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 40 40
Lines 52924 52924
Branches 1115 1115
=======================================
Hits 51839 51839
Misses 851 851
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wmundev
changed the title
twcclegg
reviewed
May 15, 2026
| - name: Run benchmarks (main branch) | ||
| if: github.event_name == 'pull_request' | ||
| run: dotnet run -c Release --framework net9.0 -- --filter "*" | ||
| run: dotnet run -c Release --framework net10.0 -- --filter "*" |
Owner
There was a problem hiding this comment.
Do we want to just merge this PR as is even though the CI is failing? It's just because net10 doesn't exist on main yet, which it will once this is merged. Or can do it as a two step process and leave this as net9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes