Homogenize tweaks (#491)#533
Open
mmontin wants to merge 14 commits into
Open
Conversation
Address the three shortcomings of the tweak DSL described in #491: - Naming consistency: rename predicate-based removal tweaks to plural form (removeInputTweak -> removeInputsTweak, removeOutputTweak -> removeOutputsTweak, removeMintTweak -> removeMintsTweak) and add a singular addMintTweak. - Missing redeemer tweaks: introduce Cooked.Tweak.Redeemers with redeemer modification tweaks for all five redeemer positions (spending, minting, proposing, withdrawing, certifying), an all-position variant, and tamperRedeemerTweak / malformRedeemerTweak mirroring the datum tweaks. modifySpendRedeemersOfTypeTweak moves here from Cooked.Tweak.Inputs. - Branch vs apply-all clarity: document the naming and branching conventions in doc/TWEAKS.md and summarize them in the Cooked.Tweak.Common haddock. Add tests for the new redeemer tweaks and update CHEATSHEET and CHANGELOG. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add and export viewAnyTweak (branching counterpart of viewAllTweak) - Remove unused iviewTweak, inlining its single use in combineModsTweak - Reimplement overMaybeSelectingTweak via selectP + elementsOf, so its position-based focus selection no longer relies on a manual counter; its select predicate is now Int -> Bool (documented in CHANGELOG) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Move the all-positions redeemer traversal from Cooked.Tweak.Redeemers to Cooked.Skeleton, exported as txSkelRedeemersT. - Reimplement txSkelInsReferenceInRedeemers on top of txSkelRedeemersT. - Replace the three duplicated allCombinations helpers with sequence from base, whose list-monad instance computes the same Cartesian product. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename three TxSkel fields and their lenses: - txSkelIns -> txSkelInputs (txSkelInsL -> txSkelInputsL) - txSkelInsReference -> txSkelReferenceInputs (txSkelInsReferenceL -> txSkelReferenceInputsL) - txSkelOuts -> txSkelOutputs (txSkelOutsL -> txSkelOutputsL) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Certificate owners are stored with an IsEither kind, but several optics and tweaks reached them through paths that forced IsScript, so their redeemers were invisible. This fixes: - txSkelRedeemersT's certifying branch (affecting txSkelReferenceInputsInRedeemers and malformRedeemerTweak), - modifyCertificateRedeemersOfTypeTweak (affecting modifyRedeemersOfTypeTweak and tamperRedeemerTweak), - autoFillReferenceScripts, which now also fills certifying reference scripts via the new txSkelRedeemedScriptsT traversal. Adds regression tests for the certificate redeemer paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace infix operators (^?, ^.., & .~) with their prefix equivalents (preview, toListOf, set) in Cooked.Tweak.Redeemers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace overMaybeTweak, overMaybeSelectingTweak and combineModsTweak with the overMods* family (overModsTweak, overModsSelectingTweak, overModsTweakAll, overModsTweakAny) plus the selectF and embedFoldable helpers. overModsTweak accumulates the labels of modified foci through a Polysemy Writer instead of addLabelTweak, which removes the Common/Labels import cycle, so the temporary Cooked.Tweak.Modifications module is merged back into Cooked.Tweak.Common and deleted. Migrate the callers accordingly: - modifyRedeemersOfTypeAtTweak and tamperDatumTweak now use overModsTweakAll; - doubleSatAttack now uses overModsTweak, branching its per-focus option lists through embedFoldable. Update the Tweak.Common tests and the CHANGELOG to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix typos, use single-quoted Haddock identifier references for cross-links, and correct grammar throughout the module. Rework the overModsTweak documentation: drop the argument bullet list that was redundant with (and had drifted out of sync with) the inline parameter docs, de-stale the worked examples to match the current signature, and restructure them to cover all three grouping strategies (all foci at once, one modification per transaction, all combinations) with cross-references to overModsTweakAll and overModsTweakAny. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the three shortcomings of the tweak DSL described in #491:
Add tests for the new redeemer tweaks and update CHEATSHEET and CHANGELOG.
fixes #491