added the key to the map and filter filters

Author: fabpot

doc/filters/filter.rst

@@ -29,6 +29,15 @@ function. The arrow function receives the value of the sequence or mapping:
     {% endfor %}
     {# output l = 40 xl = 42 #}
 
+The arrow function also receives the key as a second argument:
+
+.. code-block:: twig
+
+    {% for k, v in sizes|filter((v, k) => v > 38 and k != "xl") -%}
+        {{ k }} = {{ v }}
+    {% endfor %}
+    {# output l = 40 #}
+
 Note that the arrow function has access to the current context.
 
 Arguments

doc/filters/map.rst

@@ -17,6 +17,18 @@ mapping. The arrow function receives the value of the sequence or mapping:
     {{ people|map(p => "#{p.first} #{p.last}")|join(', ') }}
     {# outputs Bob Smith, Alice Dupond #}
 
+The arrow function also receives the key as a second argument:
+
+.. code-block:: twig
+
+    {% set people = {
+        "Bob": "Smith",
+        "Alice": "Dupond",
+    } %}
+
+    {{ people|map((first, last) => "#{first} #{last}")|join(', ') }}
+    {# outputs Bob Smith, Alice Dupond #}
+
 Note that the arrow function has access to the current context.
 
 Arguments

src/Extension/CoreExtension.php

@@ -1689,6 +1689,10 @@ function twig_array_batch($items, $size, $fill = null, $preserveKeys = true)
 function twig_array_filter($array, $arrow)
 {
     if (\is_array($array)) {
+        if (\PHP_VERSION_ID >= 50600) {
+            return array_filter($array, $arrow, \ARRAY_FILTER_USE_BOTH);
+        }
+
         return array_filter($array, $arrow);
     }
 
@@ -1697,11 +1701,12 @@ function twig_array_filter($array, $arrow)
 
 function twig_array_map($array, $arrow)
 {
-    if (!\is_array($array)) {
-        $array = iterator_to_array($array);
+    $r = [];
+    foreach ($array as $k => $v) {
+        $r[$k] = $arrow($v, $k);
     }
 
-    return array_map($arrow, $array);
+    return $r;
 }
 
 function twig_array_reduce($array, $arrow, $initial = null)

test/Twig/Tests/Fixtures/filters/filter.test

@@ -7,7 +7,7 @@
     {{ k }} = {{ v }}
 {% endfor %}
 
-{% for k, v in {a: 1, b: 2, c: 5, d: 2}|filter((v) => v > offset) -%}
+{% for k, v in {a: 1, b: 2, c: 5, d: 8}|filter(v => v > offset) -%}
     {{ k }} = {{ v }}
 {% endfor %}
 
@@ -19,16 +19,18 @@
     {{ k }} = {{ v }}
 {% endfor %}
 --DATA--
-return ['it' => new \ArrayIterator(['a' => 1, 'b' => 2, 'c' => 5, 'd' => 2])]
+return ['it' => new \ArrayIterator(['a' => 1, 'b' => 2, 'c' => 5, 'd' => 8])]
 --EXPECT--
 1 = 5
 3 = 4
 4 = 5
 
 c = 5
+d = 8
 
 1 = 5
 3 = 4
 4 = 5
 
 c = 5
+d = 8

test/Twig/Tests/Fixtures/filters/filter_php_56.test

@@ -0,0 +1,20 @@
+--TEST--
+"filter" filter (PHP 5.6 required)
+--CONDITION--
+version_compare(phpversion(), '5.6.0', '>=')
+--TEMPLATE--
+{% set offset = 3 %}
+
+{% for k, v in {a: 1, b: 2, c: 5, d: 8}|filter((v, k) => (v > offset) and (k != "d")) -%}
+    {{ k }} = {{ v }}
+{% endfor %}
+
+{% for k, v in it|filter((v, k) => (v > offset) and (k != "d")) -%}
+    {{ k }} = {{ v }}
+{% endfor %}
+--DATA--
+return ['it' => new \ArrayIterator(['a' => 1, 'b' => 2, 'c' => 5, 'd' => 8])]
+--EXPECT--
+c = 5
+
+c = 5

test/Twig/Tests/Fixtures/filters/map.test

@@ -11,6 +11,10 @@
     {{ k }} = {{ v }}
 {% endfor %}
 
+{% for k, v in {a: 1, b: 2}|map((item, k) => item ~ "*" ~ k ) -%}
+    {{ k }} = {{ v }}
+{% endfor %}
+
 {% for k, v in [1, 2]|map(item => item + 2 ) -%}
     {{ k }} = {{ v }}
 {% endfor %}
@@ -27,6 +31,9 @@ return ['it' => new \ArrayIterator([1, 2])]
 a = 1*
 b = 2*
 
+a = 1*a
+b = 2*b
+
 0 = 3
 1 = 4