feat(runtime-handler): export Response class for testing#552
Open
wittyreference wants to merge 1 commit intotwilio-labs:mainfrom
Open
feat(runtime-handler): export Response class for testing#552wittyreference wants to merge 1 commit intotwilio-labs:mainfrom
wittyreference wants to merge 1 commit intotwilio-labs:mainfrom
Conversation
Export the Response class from the package root, enabling unit testing of
Twilio Functions without custom mock implementations.
Previously, the main entry point was a placeholder that threw on import.
Now require('@twilio/runtime-handler') returns { Response }, providing
the same class used by the local dev server with full method support
(setStatusCode, setBody, appendHeader, setCookie, etc).
Closes twilio-labs#384
🦋 Changeset detectedLatest commit: c0704b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export the
Responseclass from@twilio/runtime-handlerso it can be used in unit tests without custom mocks.Closes #384
Problem
Every developer testing Twilio Functions must create their own mock
Responseclass because the real implementation is internal to the runtime-handler package. The package'sindex.tswas literally// placeholderand the main entry threw on import.Solution
Responsefromsrc/index.tspackage.jsonmain/types to point to the real index./testingsubpath export for explicit test usageUsage
Testing
All 52 test suites pass (410 tests). The
runtime-handler.test.tsnow verifies the export works with method presence checks.