fix(twilio-run): recover from stale .twiliodeployinfo cache on deploy#553
Open
wittyreference wants to merge 1 commit intotwilio-labs:mainfrom
Open
fix(twilio-run): recover from stale .twiliodeployinfo cache on deploy#553wittyreference wants to merge 1 commit intotwilio-labs:mainfrom
wittyreference wants to merge 1 commit intotwilio-labs:mainfrom
Conversation
When a service is deleted externally (via Console, API, or CI teardown) but .twiliodeployinfo still caches the old service SID, subsequent deploys fail with a confusing 20404 error. Now, when deploy encounters a 20404 (service not found), it: 1. Logs a warning identifying the stale SID 2. Clears the stale entry from .twiliodeployinfo 3. Retries the deployment without the cached SID Also adds clearDeployInfoCache() utility for targeted cache invalidation.
🦋 Changeset detectedLatest commit: 0bec080 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically recover when .twiliodeployinfo contains a stale service SID. When a service is deleted externally but the cache still references it, deploy now detects the 20404 error, clears the stale entry, and retries. No behavior change for the happy path. Adds clearDeployInfoCache() utility. All 52 test suites pass.