Cast selected JWT config values from env() for type safety#2293
Open
samironbarai wants to merge 1 commit into
Open
Cast selected JWT config values from env() for type safety#2293samironbarai wants to merge 1 commit into
samironbarai wants to merge 1 commit into
Conversation
- Cast 'ttl', 'refresh_ttl', 'leeway' to int to ensure numeric behavior - Cast 'blacklist_enabled' to bool for proper boolean handling - Improves robustness and prevents subtle bugs from string values in .env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
config/config.phpfile to ensure certain configuration values read from.envare properly typed.Changes include:
Cast numeric values to
(int):ttlrefresh_ttlleewayCast boolean value to
(bool):blacklist_enabledReasoning:
Values returned from
env()are strings by default. Explicit casting ensures these configuration values are handled correctly by the package, preventing subtle bugs caused by string values in numeric or boolean contexts.Impact:
Testing:
ttl,refresh_ttl,leewayreturn integers, andblacklist_enabledreturns a boolean.