Cast JWT_TTL and related env values to int to avoid Carbon type errors#2296
Open
MustafaAMaklad wants to merge 1 commit into
Open
Cast JWT_TTL and related env values to int to avoid Carbon type errors#2296MustafaAMaklad wants to merge 1 commit into
MustafaAMaklad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8+ and recent Carbon versions are stricter about argument types.
Environment variables are always loaded as strings, which causes
Carbon::rawAddUnit() to throw a type error when JWT_TTL is used.
This PR explicitly casts numeric JWT config values to int, aligning with
Laravel config best practices and preventing runtime errors after upgrades.