Required adapter/serializer methods should be marked as abstract?

[chancancode]

Which package(s) does this problem pertain to?

• @types/ember
• @types/ember__string
• @types/ember__polyfills
• @types/ember__object
• @types/ember__utils
• @types/ember__array
• @types/ember__engine
• @types/ember__debug
• @types/ember__runloop
• @types/ember__error
• @types/ember__controller
• @types/ember__component
• @types/ember__routing
• @types/ember__application
• @types/ember__test
• @types/ember__test-helpers
• @types/ember__service
• @types/ember-data
• @types/rsvp
• Other
• I don't know

[runspired]

This is complicated because there are two competing things here:

• the interface that adapters/serializers must conform to, specified here and here
• the optional base adapter/serializer that is a legacy remnant of when typescript didn't exist and attempted to serve as an abstract class (which you pretty much should NEVER extend but folks do), located here and here

I understand that @types/ember-data tries to type the whole surface, and so these legacy remnants need typed (and probably should be typed as abstract), but a better solution would be to expose the interfaces.

The existing RFC for types support in the ember ecosystem will eventually lead to this being the case, but I'd propose that until then fake imports be provided from where these things live in the docs. Specifically:

import { MinimumAdapterInterface } from '@ember-data/adapter';
import { MinimumSerializerInterface } from '@ember-data/serializer';