Update bookstore functions for function optionality changes#43
Open
krishnangovindraj wants to merge 4 commits into
Open
Update bookstore functions for function optionality changes#43krishnangovindraj wants to merge 4 commits into
krishnangovindraj wants to merge 4 commits into
Conversation
krishnangovindraj
changed the title
alexjpwalker
requested changes
May 7, 2026
| return { $line-total }; | ||
|
|
||
| fun best_discount_for_item($item: book, $order-time: datetime) -> double: | ||
| fun best_discount_for_item($item: book, $order-time: datetime) -> double?: |
Member
There was a problem hiding this comment.
This is odd. At first reading if $inclusion has discount $discount-attr fails to match then $discount gets set to 0.0. So surely $discount consistently ends up set to a double here, thus max($discount) is also consistently a double? Why does it need to be optional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product change and motivation
Updates bookstore functions for function optionality changes (typedb/typedb#7730)