Preserve row type in merge_annotations_from_custom_method#3383
Merged
sobolevn merged 1 commit intoMay 13, 2026
Merged
Conversation
1 task
Contributor
|
Thanks! I can confirm this removes 72 errors from the django-stubs upgrade for us and we have no more "is not indexable" errors left after this 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test example, before slicing the queryset type is
QuerySet[Foo@AnnotatedWith[...], int](model arg is the annotated Foo, row arg is int).The hook ran
copy_modified(args=[annotated_type, annotated_type]), which threw away the int and replaced it with the annotated model. With this change, the hook swaps it to the annotated model only if it was previously a model too.Related issues
Fixes #3381
AI Policy