As of MMS 11.1.0, we only checksum (which is the default) on download and after extraction, but we do no check the binaries again when trying to start them, leading to potentially corrupted binaries.
Example: let MMS download and extract it partially, kill the script and see that the file is corrupt (though that is not likely to be consistently reproducable). (re #990 (comment))
Implementation suggestions:
- store the checksum alongside the binaries (must be generated after extracting as checksum downloaded is for the entire archive)
- add a option to run a checksum on the binaries before each start
- add basic corrupt detection that does not rely on the checksum (like 0-size files or below a threshold of reasonable binary size)
As of MMS 11.1.0, we only checksum (which is the default) on download and after extraction, but we do no check the binaries again when trying to start them, leading to potentially corrupted binaries.
Example: let MMS download and extract it partially, kill the script and see that the file is corrupt (though that is not likely to be consistently reproducable). (re #990 (comment))
Implementation suggestions: