fix(mobile): resolve all high priority type safety issues

batalabs · batalabs · commit 076000d3ff74 · 2025-10-11T12:01:10.000-04:00
diff --git a/apps/mobile/v1/src/components/settings/UsageBottomSheet.tsx b/apps/mobile/v1/src/components/settings/UsageBottomSheet.tsx
@@ -5,6 +5,7 @@ import {
   BottomSheetView,
   BottomSheetBackdrop,
   BottomSheetScrollView,
+  BottomSheetBackdropProps,
 } from '@gorhom/bottom-sheet';
 import { Ionicons } from '@expo/vector-icons';
 import { useApiService, type ApiUserUsage } from '@/src/services/api';
@@ -50,7 +51,7 @@ export function UsageBottomSheet({ sheetRef, snapPoints }: UsageBottomSheetProps
   };
 
   const renderBackdrop = React.useCallback(
-    (props: any) => (
+    (props: BottomSheetBackdropProps) => (
       <BottomSheetBackdrop
         {...props}
         disappearsOnIndex={-1}
diff --git a/apps/mobile/v1/src/lib/logger.ts b/apps/mobile/v1/src/lib/logger.ts
@@ -5,7 +5,23 @@
 
 import { Platform } from 'react-native';
 
-let NewRelic: any = null;
+/**
+ * Type definitions for New Relic SDK
+ * Based on newrelic-react-native-agent API
+ */
+interface NewRelicSDK {
+  setUserId?: (userId: string) => void;
+  setAttribute?: (name: string, value: string | number | boolean) => void;
+  recordError?: (error: Error) => void;
+  logDebug?: (message: string, attributes?: Record<string, unknown>) => void;
+  logInfo?: (message: string, attributes?: Record<string, unknown>) => void;
+  logWarning?: (message: string, attributes?: Record<string, unknown>) => void;
+  logError?: (message: string, attributes?: Record<string, unknown>) => void;
+  recordCustomEvent?: (eventName: string, attributes?: Record<string, unknown>) => void;
+  recordBreadcrumb?: (name: string, attributes?: Record<string, unknown>) => void;
+}
+
+let NewRelic: NewRelicSDK | null = null;
 
 // Initialize New Relic reference
 try {
@@ -24,7 +40,7 @@ export enum LogLevel {
 
 interface LogOptions {
   /** Additional attributes to attach to the log */
-  attributes?: Record<string, any>;
+  attributes?: Record<string, unknown>;
   /** Whether to only send to New Relic (skip console) */
   newRelicOnly?: boolean;
 }
@@ -35,7 +51,7 @@ interface LogOptions {
 class Logger {
   private isNewRelicAvailable: boolean;
   private userId: string | null = null;
-  private sessionAttributes: Record<string, any> = {};
+  private sessionAttributes: Record<string, unknown> = {};
 
   constructor() {
     this.isNewRelicAvailable = NewRelic !== null;
@@ -57,7 +73,7 @@ class Logger {
   /**
    * Set session-level attributes that will be included in all logs
    */
-  setSessionAttributes(attributes: Record<string, any>): void {
+  setSessionAttributes(attributes: Record<string, unknown>): void {
     this.sessionAttributes = { ...this.sessionAttributes, ...attributes };
 
     // Set each attribute in New Relic
@@ -197,7 +213,7 @@ class Logger {
   /**
    * Record a custom event in New Relic
    */
-  recordEvent(eventName: string, attributes?: Record<string, any>): void {
+  recordEvent(eventName: string, attributes?: Record<string, unknown>): void {
     if (this.isNewRelicAvailable && NewRelic.recordCustomEvent) {
       NewRelic.recordCustomEvent(eventName, attributes);
     }
@@ -223,7 +239,7 @@ class Logger {
   /**
    * Record a breadcrumb (useful for tracking user flow)
    */
-  breadcrumb(name: string, attributes?: Record<string, any>): void {
+  breadcrumb(name: string, attributes?: Record<string, unknown>): void {
     if (this.isNewRelicAvailable && NewRelic.recordBreadcrumb) {
       NewRelic.recordBreadcrumb(name, attributes);
     }
diff --git a/apps/mobile/v1/src/screens/FoldersScreen.tsx b/apps/mobile/v1/src/screens/FoldersScreen.tsx
@@ -8,7 +8,7 @@ import { useTheme } from '../theme';
 import { Ionicons } from '@expo/vector-icons';
 import { useApiService, type Folder } from '../services/api';
 import { FOLDER_CARD, ACTION_BUTTON, FOLDER_COLORS } from '../constants/ui';
-import { BottomSheetModal, BottomSheetView, BottomSheetBackdrop, BottomSheetTextInput } from '@gorhom/bottom-sheet';
+import { BottomSheetModal, BottomSheetView, BottomSheetBackdrop, BottomSheetTextInput, BottomSheetBackdropProps } from '@gorhom/bottom-sheet';
 
 // Special views configuration matching web app
 const SPECIAL_VIEWS = [
@@ -74,7 +74,7 @@ export default function FoldersScreen() {
 
   // Backdrop component
   const renderBackdrop = useCallback(
-    (props: any) => (
+    (props: BottomSheetBackdropProps) => (
       <BottomSheetBackdrop
         {...props}
         disappearsOnIndex={-1}
diff --git a/apps/mobile/v1/src/screens/NotesListScreen.tsx b/apps/mobile/v1/src/screens/NotesListScreen.tsx
@@ -7,7 +7,7 @@ import { useTheme } from '../theme';
 import { useApiService, type Note, type Folder } from '../services/api';
 import { Ionicons } from '@expo/vector-icons';
 import { NOTE_CARD, FOLDER_CARD, SECTION, FOLDER_COLORS } from '../constants/ui';
-import { BottomSheetModal, BottomSheetView, BottomSheetBackdrop, BottomSheetTextInput } from '@gorhom/bottom-sheet';
+import { BottomSheetModal, BottomSheetView, BottomSheetBackdrop, BottomSheetTextInput, BottomSheetBackdropProps } from '@gorhom/bottom-sheet';
 
 interface RouteParams {
   folderId?: string;
@@ -81,7 +81,7 @@ export default function NotesListScreen({ navigation, route, renderHeader, scrol
 
   // Backdrop component
   const renderBackdrop = useCallback(
-    (props: any) => (
+    (props: BottomSheetBackdropProps) => (
       <BottomSheetBackdrop
         {...props}
         disappearsOnIndex={-1}
diff --git a/apps/mobile/v1/src/screens/SettingsScreen.tsx b/apps/mobile/v1/src/screens/SettingsScreen.tsx
@@ -9,11 +9,14 @@ import { Card } from '../components/ui/Card';
 import { Ionicons } from '@expo/vector-icons';
 import { clearUserEncryptionData } from '../lib/encryption';
 import { forceGlobalMasterPasswordRefresh } from '../hooks/useMasterPassword';
-import { BottomSheetModal, BottomSheetView, BottomSheetBackdrop, BottomSheetScrollView } from '@gorhom/bottom-sheet';
+import { BottomSheetModal, BottomSheetView, BottomSheetBackdrop, BottomSheetScrollView, BottomSheetBackdropProps } from '@gorhom/bottom-sheet';
 import AsyncStorage from '@react-native-async-storage/async-storage';
 import { APP_VERSION } from '../constants/version';
 import { UsageBottomSheet } from '../components/settings/UsageBottomSheet';
 
+// Type for valid Ionicons names
+type IconName = keyof typeof Ionicons.glyphMap;
+
 interface Props {
   onLogout?: () => void;
 }
@@ -45,7 +48,7 @@ export default function SettingsScreen({ onLogout }: Props) {
 
   // Backdrop component
   const renderBackdrop = useCallback(
-    (props: any) => (
+    (props: BottomSheetBackdropProps) => (
       <BottomSheetBackdrop
         {...props}
         disappearsOnIndex={-1}
@@ -288,7 +291,7 @@ export default function SettingsScreen({ onLogout }: Props) {
                         }
                       ]}>
                         <Ionicons
-                          name={item.icon as any}
+                          name={item.icon as IconName}
                           size={20}
                           color={theme.colors.foreground}
                         />
@@ -370,12 +373,12 @@ export default function SettingsScreen({ onLogout }: Props) {
                 key={option.mode}
                 style={[styles.optionItem, { backgroundColor: theme.colors.card, borderColor: theme.colors.border }]}
                 onPress={() => {
-                  theme.setThemeMode(option.mode as any);
+                  theme.setThemeMode(option.mode);
                   themeModeSheetRef.current?.dismiss();
                 }}
               >
                 <View style={[styles.optionIcon, { backgroundColor: theme.colors.muted }]}>
-                  <Ionicons name={option.icon as any} size={20} color={theme.colors.foreground} />
+                  <Ionicons name={option.icon as IconName} size={20} color={theme.colors.foreground} />
                   </View>
                   <View style={styles.optionText}>
                     <Text style={[styles.optionTitle, { color: theme.colors.foreground }]}>
@@ -436,7 +439,7 @@ export default function SettingsScreen({ onLogout }: Props) {
                     { backgroundColor: theme.colors.card, borderColor: theme.colors.border }
                   ]}
                   onPress={() => {
-                    theme.setLightTheme(preset.id as any);
+                    theme.setLightTheme(preset.id);
                   }}
                 >
                   <View style={[styles.colorPreview, {
@@ -476,7 +479,7 @@ export default function SettingsScreen({ onLogout }: Props) {
                     { backgroundColor: theme.colors.card, borderColor: theme.colors.border }
                   ]}
                   onPress={() => {
-                    theme.setDarkTheme(preset.id as any);
+                    theme.setDarkTheme(preset.id);
                   }}
                 >
                   <View style={[styles.colorPreview, {
@@ -623,7 +626,7 @@ export default function SettingsScreen({ onLogout }: Props) {
                 }}
               >
                 <View style={[styles.optionIcon, { backgroundColor: theme.colors.muted }]}>
-                  <Ionicons name={option.icon as any} size={20} color={theme.colors.foreground} />
+                  <Ionicons name={option.icon as IconName} size={20} color={theme.colors.foreground} />
                 </View>
                 <View style={styles.optionText}>
                   <Text style={[styles.optionTitle, { color: theme.colors.foreground }]}>
diff --git a/apps/mobile/v1/src/services/api/utils/pagination.ts b/apps/mobile/v1/src/services/api/utils/pagination.ts
@@ -11,7 +11,8 @@ interface PaginationResponse<T> {
     total: number;
     limit: number;
     page: number;
-    totalPages: number;
+    totalPages?: number;
+    pages?: number; // Some APIs use 'pages' instead of 'totalPages'
   };
   total?: number;
   limit?: number;
@@ -68,9 +69,9 @@ function determineHasMorePages<T>(
 
   // Check for pagination object
   if (resp.pagination) {
-    const { page, totalPages, pages } = resp.pagination as any;
-    // API uses 'pages' not 'totalPages'
-    const total = totalPages || pages;
+    const { page, totalPages, pages } = resp.pagination;
+    // API uses 'pages' not 'totalPages', so check both
+    const total = totalPages ?? pages;
     if (total !== undefined) {
       return page < total;
     }
