fix(mobile): resolve editor Enter key behavior and improve code quality

batalabs · batalabs · commit 12769de91922 · 2025-10-28T06:43:42.000-04:00
- Fix: Editor Enter key now properly splits content in lists and paragraphs
    - Bullet lists: Extract content after cursor when pressing Enter mid-line
    - Ordered lists: Extract content after cursor when pressing Enter mid-line
    - Paragraphs: Expand range to end of block before extracting content
    - Root cause: Collapsed range wasn't expanding before extractContents()

  - Chore: Add ESLint import sorting and apply formatting
    - Configure eslint-plugin-simple-import-sort
    - Auto-sort imports across all files
    - Add lint:fix npm script

  - Refactor: Improve Sentry logging with structured categories
    - Add category prefixes: [NOTE], [AUTH], [ERROR], [ENCRYPTION], etc.
    - Add structured attributes for better filtering
    - Remove NewRelic-specific code and sentry.ts utility file
    - Enable Sentry structured logs in index.js

  - Chore: Remove unused code and dependencies
    - Delete unused files: haptic-tab.tsx, useNoteEditor.ts, styles.ts
    - Remove TenTap editor and Pell editor dependencies
    - Clean up route file exports
diff --git a/apps/mobile/v1/src/screens/ViewNote/NoteContent.tsx b/apps/mobile/v1/src/screens/ViewNote/NoteContent.tsx
@@ -45,7 +45,9 @@ export function NoteContent({
     <html lang="en">
     <head>
       <meta name="viewport" content="width=device-width, initial-scale=1.0">
+      <!-- noinspection HtmlUnknownTarget,JSUnresolvedLibraryURL -->
       <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/atom-one-dark.min.css" crossorigin="anonymous">
+      <!-- noinspection HtmlUnknownTarget,JSUnresolvedLibraryURL -->
       <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/highlight.min.js" crossorigin="anonymous"></script>
       <style>
         body {
@@ -140,6 +142,7 @@ export function NoteContent({
 
         pre {
           background-color: ${theme.isDark ? 'rgba(255, 255, 255, 0.05)' : theme.colors.muted};
+          /* noinspection CssInvalidPropertyValue */
           border: 1px solid ${theme.colors.border};
           border-radius: 6px;
           padding: 12px 16px;
@@ -163,6 +166,7 @@ export function NoteContent({
           color: ${theme.isDark ? '#ffffff' : 'inherit'} !important;
         }
 
+        /* noinspection CssInvalidFunction,JSUnresolvedReference,JSValidateTypes */
         ${htmlContent.match(/<style>([\s\S]*?)<\/style>/)?.[1] || ''}
 
         /* Override any extracted styles with our custom spacing */
@@ -207,11 +211,13 @@ export function NoteContent({
         hr {
           margin: 16px 0;
           border: none;
+          /* noinspection CssInvalidPropertyValue */
           border-top: 1px solid ${theme.colors.border};
         }
 
         /* Blockquotes */
         blockquote {
+          /* noinspection CssInvalidPropertyValue */
           border-left: 4px solid ${theme.colors.border};
           padding-left: 16px;
           margin: 12px 0;
diff --git a/apps/mobile/v1/src/services/fileService.ts b/apps/mobile/v1/src/services/fileService.ts
@@ -55,7 +55,9 @@ class FileService {
 
   /**
    * Convert base64 to Uint8Array
+   * @deprecated Not currently used - keeping for potential future use
    */
+  // noinspection JSUnusedLocalSymbols
   private base64ToUint8Array(base64: string): Uint8Array {
     const binary = forge.util.decode64(base64);
     const bytes = new Uint8Array(binary.length);
@@ -287,6 +289,7 @@ class FileService {
       if (!response.ok) {
         const errorText = await response.text();
         console.error('[ERROR] Download failed:', response.status, errorText);
+        // noinspection ExceptionCaughtLocallyJS - Intentionally caught locally for logging before re-throw
         throw new Error(`${response.status} ${errorText}`);
       }
 
@@ -370,7 +373,8 @@ class FileService {
     if (bytes === 0) return '0 Bytes';
     const k = 1024;
     const sizes = ['Bytes', 'KB', 'MB', 'GB'];
-    const i = Math.floor(Math.log(bytes) / Math.log(k));
+    // noinspection JSVoidFunctionReturnValueUsed
+    const i = Math.min(Math.floor(Math.log(bytes) / Math.log(k)), sizes.length - 1);
     return parseFloat((bytes / Math.pow(k, i)).toFixed(2)) + ' ' + sizes[i];
   }
 
