fix(mobile): replace all arrayBufferToBase64 usage with node-forge

Author: batalabs

apps/mobile/v1/src/lib/encryption/EncryptionService.ts

@@ -4,11 +4,11 @@
  */
 
 import * as Crypto from 'expo-crypto';
+import forge from 'node-forge';
 import { EncryptedNote, DecryptedData, PotentiallyEncrypted } from './types';
 import { ENCRYPTION_CONFIG } from './config';
 import { encryptWithAESGCM, decryptWithAESGCM } from './core/aes';
 import { deriveEncryptionKey } from './core/keyDerivation';
-import { arrayBufferToBase64 } from './core/crypto';
 import { getUserSecret, getMasterKey, clearUserStorageData } from './storage/secureStorage';
 import { DecryptionCache } from './storage/cache';
 
@@ -61,9 +61,11 @@ export class MobileEncryptionService {
       const saltBytes = await Crypto.getRandomBytesAsync(ENCRYPTION_CONFIG.SALT_LENGTH);
       const ivBytes = await Crypto.getRandomBytesAsync(ENCRYPTION_CONFIG.IV_LENGTH);
 
-      // Convert to base64
-      const saltBase64 = arrayBufferToBase64(saltBytes);
-      const ivBase64 = arrayBufferToBase64(ivBytes);
+      // Convert Uint8Array to base64 using node-forge
+      const saltString = String.fromCharCode.apply(null, Array.from(saltBytes));
+      const ivString = String.fromCharCode.apply(null, Array.from(ivBytes));
+      const saltBase64 = forge.util.encode64(saltString);
+      const ivBase64 = forge.util.encode64(ivString);
 
       // Derive encryption key
       const key = await this.deriveKey(userId, saltBase64);

apps/mobile/v1/src/lib/encryption/storage/cache.ts

@@ -8,7 +8,7 @@ import { CACHE_CONFIG } from '../config';
 
 export class DecryptionCache {
   private cache = new Map<string, CacheEntry>();
-  private cleanupInterval: NodeJS.Timeout;
+  private cleanupInterval: ReturnType<typeof setInterval>;
 
   constructor() {
     // Clean expired cache every 5 minutes

apps/mobile/v1/src/lib/encryption/storage/secureStorage.ts

@@ -6,7 +6,7 @@
 import * as SecureStore from 'expo-secure-store';
 import * as Crypto from 'expo-crypto';
 import { STORAGE_KEYS } from './storageKeys';
-import { arrayBufferToBase64 } from '../core/crypto';
+import forge from 'node-forge';
 
 /**
  * User secret management - in-memory cache
@@ -28,8 +28,9 @@ export async function getUserSecret(userId: string): Promise<string> {
   }
 
   // Check memory cache
-  if (userSecretsCache.has(userId)) {
-    return userSecretsCache.get(userId)!;
+  const cachedSecret = userSecretsCache.get(userId);
+  if (cachedSecret) {
+    return cachedSecret;
   }
 
   // Use secure storage for user secrets
@@ -40,7 +41,9 @@ export async function getUserSecret(userId: string): Promise<string> {
     if (!secret) {
       // Generate new random secret and store it securely
       const randomBytes = await Crypto.getRandomBytesAsync(64);
-      secret = arrayBufferToBase64(randomBytes);
+      // Convert Uint8Array to base64 using node-forge
+      const randomString = String.fromCharCode.apply(null, Array.from(randomBytes));
+      secret = forge.util.encode64(randomString);
       await SecureStore.setItemAsync(storageKey, secret);
     }