Skip to content

fix(mobile): resolve master password setup hang and add New Relic mon…#19

Merged
typelets merged 1 commit intomainfrom
fix/mobile-master-password-loading
Oct 9, 2025
Merged

fix(mobile): resolve master password setup hang and add New Relic mon…#19
typelets merged 1 commit intomainfrom
fix/mobile-master-password-loading

Conversation

@typelets
Copy link
Copy Markdown
Owner

@typelets typelets commented Oct 9, 2025

Fix Master Password Setup Hang & Add New Relic Monitoring

Problem

Master password setup appeared frozen during new account creation, requiring users to restart the app. The loading screen never rendered because the synchronous PBKDF2 operation (250k iterations, 2-5 minutes) blocked the UI thread immediately.

Solution

  • Added InteractionManager to defer PBKDF2 until after UI renders
  • Implemented animated loading screen with clear messaging about wait time
  • Improved error handling and state management for better recovery
  • Integrated New Relic monitoring for crash reporting and analytics

Changes

Master Password Loading:

  • keyDerivation.ts - InteractionManager ensures loading UI renders first
  • LoadingView.tsx - Animated dots + "This can take 2-5 minutes" message
  • useMasterPassword.ts - Better error handling and state updates
  • MasterPasswordDialog/index.tsx - Prevents stuck loading states

New Relic Integration:

  • index.js - Agent initialization with platform-specific tokens
  • package.json - Added newrelic-react-native-agent dependency
  • android/build.gradle - New Relic plugin v7.6.9 (AGP 8.x compatible)

Code Quality:

  • Removed debug console.logs
  • Fixed ESLint warnings

Testing

  • ✅ New account creation with master password setup works
  • ✅ Loading screen displays immediately
  • ✅ App transitions properly after completion
  • ✅ Error recovery on invalid password
  • ✅ TypeScript and lint checks pass

Security

  • Maintains 250k PBKDF2 iterations (matches web app)
  • No sensitive data logged

@typelets typelets merged commit d2877df into main Oct 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

🎉 This PR is included in version 1.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants