fix(mobile): resolve master password setup hang and add New Relic mon…#19
Merged
fix(mobile): resolve master password setup hang and add New Relic mon…#19
Conversation
Contributor
|
🎉 This PR is included in version 1.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Master Password Setup Hang & Add New Relic Monitoring
Problem
Master password setup appeared frozen during new account creation, requiring users to restart the app. The loading screen never rendered because the synchronous PBKDF2 operation (250k iterations, 2-5 minutes) blocked the UI thread immediately.
Solution
InteractionManagerto defer PBKDF2 until after UI rendersChanges
Master Password Loading:
keyDerivation.ts- InteractionManager ensures loading UI renders firstLoadingView.tsx- Animated dots + "This can take 2-5 minutes" messageuseMasterPassword.ts- Better error handling and state updatesMasterPasswordDialog/index.tsx- Prevents stuck loading statesNew Relic Integration:
index.js- Agent initialization with platform-specific tokenspackage.json- Addednewrelic-react-native-agentdependencyandroid/build.gradle- New Relic plugin v7.6.9 (AGP 8.x compatible)Code Quality:
Testing
Security